netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: phil@nwl.cc
Subject: Re: [PATCH nft] owner: Fix potential array out of bounds access
Date: Wed, 21 Dec 2022 17:41:17 +0100	[thread overview]
Message-ID: <Y6M3LQU5rXnNw1DX@salvia> (raw)
In-Reply-To: <20221221163746.63408-1-pablo@netfilter.org>

On Wed, Dec 21, 2022 at 05:37:46PM +0100, Pablo Neira Ayuso wrote:
> If the link target length exceeds 'sizeof(tmp)' bytes, readlink() will
> return 'sizeof(tmp)'. Using this value as index is illegal.
> 
> Original update from Phil, for the conntrack-tools tree, which also has
> a copy of this function.

For the record: If this code is generalized, this code is a candidate
for libmnl I think.

      reply	other threads:[~2022-12-21 16:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-21 16:37 [PATCH nft] owner: Fix potential array out of bounds access Pablo Neira Ayuso
2022-12-21 16:41 ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y6M3LQU5rXnNw1DX@salvia \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).