[iptables PATCH] Makefile: Replace brace expansion

[iptables PATCH] Makefile: Replace brace expansion

[Phil Sutter]

According to bash(1), it is not supported by "historical versions of
sh". Dash seems to be such a historical version.

Reported-by: Pablo Neira Ayuso <pablo@netfilter.org>
Fixes: 3822a992bc277 ("Makefile: Fix for 'make distcheck'")
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
 extensions/GNUmakefile.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/extensions/GNUmakefile.in b/extensions/GNUmakefile.in
index c37e4619f91f9..e289adf06547f 100644
--- a/extensions/GNUmakefile.in
+++ b/extensions/GNUmakefile.in
@@ -106,7 +106,8 @@ install: ${targets_install} ${symlinks_install}
 	}
 
 clean:
-	rm -f *.o *.oo *.so *.a {matches,targets}.man initext.c initext4.c initext6.c initextb.c initexta.c;
+	rm -f *.o *.oo *.so *.a matches.man targets.man
+	rm -f initext.c initext4.c initext6.c initextb.c initexta.c
 	rm -f .*.d .*.dd;
 
 distclean: clean
@@ -243,7 +244,7 @@ dist_sources = $(filter-out ${dist_initext_src},$(wildcard $(srcdir)/*.[ch]))
 	mkdir -p $(distdir)
 	cp -p ${dist_sources} $(distdir)/
 	cp -p $(wildcard ${srcdir}/lib*.man) $(distdir)/
-	cp -p $(srcdir)/*.{t,txlate} $(distdir)/
+	cp -p $(wildcard ${srcdir}/*.t ${srcdir}/*.txlate) $(distdir)/
 
 dvi:
 check: all
-- 
2.38.0

Re: [iptables PATCH] Makefile: Replace brace expansion

[Phil Sutter]

On Tue, Jan 10, 2023 at 05:35:02PM +0100, Phil Sutter wrote:
> According to bash(1), it is not supported by "historical versions of
> sh". Dash seems to be such a historical version.
> 
> Reported-by: Pablo Neira Ayuso <pablo@netfilter.org>
> Fixes: 3822a992bc277 ("Makefile: Fix for 'make distcheck'")
> Signed-off-by: Phil Sutter <phil@nwl.cc>

Patch applied.