build failure since commit 'xt: Rewrite unsupported compat expression dumping'

build failure since commit 'xt: Rewrite unsupported compat expression dumping'

[Neels Hofmeyr]

Hi,

building current master of https://git.netfilter.org/nftables i get a build
error that i didn't see a few weeks ago. I thought I'd report it here.

I bisected to identify this commit to be the start of build failures for me:

 commit 79195a8cc9e9d9cf2d17165bf07ac4cc9d55539f
 Author: Phil Sutter <phil@nwl.cc>
 Date:   Thu Nov 24 14:17:17 2022 +0100
 "xt: Rewrite unsupported compat expression dumping"

This is the build error at above commit:

   CC       xt.lo
   CC       libparser_la-scanner.lo
 ../src/nftables/src/scanner.l: In function 'nft_lex':
 ../src/nftables/src/scanner.l:804:60: error: 'XT' undeclared (first use in this function); did you mean 'CT'?
 ../src/nftables/src/scanner.l:804:60: note: each undeclared identifier is reported only once for each function it appears in

On 'master', the build error is different:

   CC       libparser_la-scanner.lo
 ../src/nftables/src/scanner.l: In function 'nft_lex':
 ../src/nftables/src/scanner.l:625:10: error: 'VXLAN' undeclared (first use in this function); did you mean 'VLAN'?
 ../src/nftables/src/scanner.l:625:10: note: each undeclared identifier is reported only once for each function it appears in
 ../src/nftables/src/scanner.l:626:10: error: 'VNI' undeclared (first use in this function)
 ../src/nftables/src/scanner.l:628:10: error: 'GENEVE' undeclared (first use in this function)
 ../src/nftables/src/scanner.l:630:61: error: 'GRE' undeclared (first use in this function); did you mean 'GTE'?
 ../src/nftables/src/scanner.l:631:61: error: 'GRETAP' undeclared (first use in this function)
 ../src/nftables/src/scanner.l:812:60: error: 'XT' undeclared (first use in this function); did you mean 'CT'?

~N

Re: build failure since commit 'xt: Rewrite unsupported compat expression dumping'

[Pablo Neira Ayuso]

Hi Neels,

On Wed, Jan 11, 2023 at 01:00:17AM +0100, Neels Hofmeyr wrote:
> Hi,
> 
> building current master of https://git.netfilter.org/nftables i get a build
> error that i didn't see a few weeks ago. I thought I'd report it here.
> 
> I bisected to identify this commit to be the start of build failures for me:
> 
>  commit 79195a8cc9e9d9cf2d17165bf07ac4cc9d55539f
>  Author: Phil Sutter <phil@nwl.cc>
>  Date:   Thu Nov 24 14:17:17 2022 +0100
>  "xt: Rewrite unsupported compat expression dumping"
> 
> This is the build error at above commit:
> 
>    CC       xt.lo
>    CC       libparser_la-scanner.lo
>  ../src/nftables/src/scanner.l: In function 'nft_lex':
>  ../src/nftables/src/scanner.l:804:60: error: 'XT' undeclared (first use in this function); did you mean 'CT'?
>  ../src/nftables/src/scanner.l:804:60: note: each undeclared identifier is reported only once for each function it appears in
> 
> On 'master', the build error is different:
> 
>    CC       libparser_la-scanner.lo
>  ../src/nftables/src/scanner.l: In function 'nft_lex':
>  ../src/nftables/src/scanner.l:625:10: error: 'VXLAN' undeclared (first use in this function); did you mean 'VLAN'?
>  ../src/nftables/src/scanner.l:625:10: note: each undeclared identifier is reported only once for each function it appears in
>  ../src/nftables/src/scanner.l:626:10: error: 'VNI' undeclared (first use in this function)
>  ../src/nftables/src/scanner.l:628:10: error: 'GENEVE' undeclared (first use in this function)
>  ../src/nftables/src/scanner.l:630:61: error: 'GRE' undeclared (first use in this function); did you mean 'GTE'?
>  ../src/nftables/src/scanner.l:631:61: error: 'GRETAP' undeclared (first use in this function)
>  ../src/nftables/src/scanner.l:812:60: error: 'XT' undeclared (first use in this function); did you mean 'CT'?

I cannot reproduce this.

Could you have a look at src/parser_bison.h? This file is
autogenerated by bison and it is included by the src/scanner.c (which
is also autogenerated).

Thanks.

Re: build failure since commit 'xt: Rewrite unsupported compat expression dumping'

[Neels Hofmeyr]

I took a closer look: dropped the build dir and did 'git clean -dxf' -- after
that indeed the build works! Possibly there is a missing dependency in the
makefiles. I suppose I should have tried that before writing the mail, sorry...

~N

Re: build failure since commit 'xt: Rewrite unsupported compat expression dumping'

[Pablo Neira Ayuso]

On Thu, Jan 12, 2023 at 03:20:25AM +0100, Neels Hofmeyr wrote:
> I took a closer look: dropped the build dir and did 'git clean -dxf' -- after
> that indeed the build works! Possibly there is a missing dependency in the
> makefiles. I suppose I should have tried that before writing the mail, sorry...

No problem, thanks for confirming things work fine there.

Re: build failure since commit 'xt: Rewrite unsupported compat expression dumping'

[Pablo Neira Ayuso]

On Thu, Jan 12, 2023 at 01:07:44PM +0100, Pablo Neira Ayuso wrote:
> On Thu, Jan 12, 2023 at 03:20:25AM +0100, Neels Hofmeyr wrote:
> > I took a closer look: dropped the build dir and did 'git clean -dxf' -- after
> > that indeed the build works! Possibly there is a missing dependency in the
> > makefiles. I suppose I should have tried that before writing the mail, sorry...
> 
> No problem, thanks for confirming things work fine there.

Still, for some reason there, it seems the .c files that are
autogenerated by bison and flex were not refreshed.