From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netfilter-devel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id D053FC5479D
	for <netfilter-devel@archiver.kernel.org>; Wed, 11 Jan 2023 09:15:59 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231294AbjAKJPz (ORCPT
        <rfc822;netfilter-devel@archiver.kernel.org>);
        Wed, 11 Jan 2023 04:15:55 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50704 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S231719AbjAKJP3 (ORCPT
        <rfc822;netfilter-devel@vger.kernel.org>);
        Wed, 11 Jan 2023 04:15:29 -0500
Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207])
        by lindbergh.monkeyblade.net (Postfix) with ESMTP id 35D702AE2
        for <netfilter-devel@vger.kernel.org>; Wed, 11 Jan 2023 01:12:09 -0800 (PST)
Date:   Wed, 11 Jan 2023 10:12:05 +0100
From:   Pablo Neira Ayuso <pablo@netfilter.org>
To:     Neels Hofmeyr <nhofmeyr@sysmocom.de>
Cc:     netfilter-devel@vger.kernel.org
Subject: Re: build failure since commit 'xt: Rewrite unsupported compat
 expression dumping'
Message-ID: <Y759ZZioewP6Ohmf@salvia>
References: <Y738EXSaHcvYLnoH@my.box>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <Y738EXSaHcvYLnoH@my.box>
Precedence: bulk
List-ID: <netfilter-devel.vger.kernel.org>
X-Mailing-List: netfilter-devel@vger.kernel.org

Hi Neels,

On Wed, Jan 11, 2023 at 01:00:17AM +0100, Neels Hofmeyr wrote:
> Hi,
> 
> building current master of https://git.netfilter.org/nftables i get a build
> error that i didn't see a few weeks ago. I thought I'd report it here.
> 
> I bisected to identify this commit to be the start of build failures for me:
> 
>  commit 79195a8cc9e9d9cf2d17165bf07ac4cc9d55539f
>  Author: Phil Sutter <phil@nwl.cc>
>  Date:   Thu Nov 24 14:17:17 2022 +0100
>  "xt: Rewrite unsupported compat expression dumping"
> 
> This is the build error at above commit:
> 
>    CC       xt.lo
>    CC       libparser_la-scanner.lo
>  ../src/nftables/src/scanner.l: In function 'nft_lex':
>  ../src/nftables/src/scanner.l:804:60: error: 'XT' undeclared (first use in this function); did you mean 'CT'?
>  ../src/nftables/src/scanner.l:804:60: note: each undeclared identifier is reported only once for each function it appears in
> 
> On 'master', the build error is different:
> 
>    CC       libparser_la-scanner.lo
>  ../src/nftables/src/scanner.l: In function 'nft_lex':
>  ../src/nftables/src/scanner.l:625:10: error: 'VXLAN' undeclared (first use in this function); did you mean 'VLAN'?
>  ../src/nftables/src/scanner.l:625:10: note: each undeclared identifier is reported only once for each function it appears in
>  ../src/nftables/src/scanner.l:626:10: error: 'VNI' undeclared (first use in this function)
>  ../src/nftables/src/scanner.l:628:10: error: 'GENEVE' undeclared (first use in this function)
>  ../src/nftables/src/scanner.l:630:61: error: 'GRE' undeclared (first use in this function); did you mean 'GTE'?
>  ../src/nftables/src/scanner.l:631:61: error: 'GRETAP' undeclared (first use in this function)
>  ../src/nftables/src/scanner.l:812:60: error: 'XT' undeclared (first use in this function); did you mean 'CT'?

I cannot reproduce this.

Could you have a look at src/parser_bison.h? This file is
autogenerated by bison and it is included by the src/scanner.c (which
is also autogenerated).

Thanks.