From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEE19C27C76 for ; Sun, 22 Jan 2023 16:22:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230094AbjAVQWI (ORCPT ); Sun, 22 Jan 2023 11:22:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229766AbjAVQWH (ORCPT ); Sun, 22 Jan 2023 11:22:07 -0500 X-Greylist: delayed 567 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Sun, 22 Jan 2023 08:22:06 PST Received: from zeeaster.vergenet.net (zeeaster.vergenet.net [206.189.110.174]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0004D1E28E; Sun, 22 Jan 2023 08:22:06 -0800 (PST) Received: from madeliefje.horms.nl (86-88-72-229.fixed.kpn.net [86.88.72.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by zeeaster.vergenet.net (Postfix) with ESMTPSA id 811E720095; Sun, 22 Jan 2023 16:12:07 +0000 (UTC) Received: by madeliefje.horms.nl (Postfix, from userid 7100) id 121EB4899; Sun, 22 Jan 2023 17:12:07 +0100 (CET) Date: Sun, 22 Jan 2023 17:12:07 +0100 From: Simon Horman To: Yang Yingliang Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, ffmancera@riseup.net Subject: Re: [PATCH net-next] netfilter: nf_tables: fix wrong pointer passed to PTR_ERR() Message-ID: References: <20230119075125.3598627-1-yangyingliang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230119075125.3598627-1-yangyingliang@huawei.com> Organisation: Horms Solutions BV X-Virus-Scanned: clamav-milter 0.103.7 at zeeaster X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Thu, Jan 19, 2023 at 03:51:25PM +0800, Yang Yingliang wrote: > It should be 'chain' passed to PTR_ERR() in the error path > after calling nft_chain_lookup() in nf_tables_delrule(). > > Fixes: f80a612dd77c ("netfilter: nf_tables: add support to destroy operation") > Signed-off-by: Yang Yingliang Reviewed-by: Simon Horman