From: Leon Romanovsky <leon@kernel.org>
To: Gavrilov Ilia <Ilia.Gavrilov@infotecs.ru>
Cc: "coreteam@netfilter.org" <coreteam@netfilter.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"fw@strlen.de" <fw@strlen.de>,
"joe@perches.com" <joe@perches.com>,
"kadlec@netfilter.org" <kadlec@netfilter.org>,
"kuba@kernel.org" <kuba@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lvc-project@linuxtesting.org" <lvc-project@linuxtesting.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"netfilter-devel@vger.kernel.org"
<netfilter-devel@vger.kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"pablo@netfilter.org" <pablo@netfilter.org>
Subject: Re: [PATCH v2] netfilter: conntrack: remote a return value of the 'seq_print_acct' function.
Date: Mon, 23 Jan 2023 19:44:58 +0200 [thread overview]
Message-ID: <Y87Hmv5qSZcD3rRZ@unreal> (raw)
In-Reply-To: <20230123143202.1785569-1-Ilia.Gavrilov@infotecs.ru>
On Mon, Jan 23, 2023 at 02:31:54PM +0000, Gavrilov Ilia wrote:
> The static 'seq_print_acct' function always returns 0.
>
> Change the return value to 'void' and remove unnecessary checks.
>
> Found by InfoTeCS on behalf of Linux Verification Center
> (linuxtesting.org) with SVACE.
>
> Fixes: 1ca9e41770cb ("netfilter: Remove uses of seq_<foo> return values")
> Signed-off-by: Ilia.Gavrilov <Ilia.Gavrilov@infotecs.ru>
> ---
> V2: Fix coding style
> net/netfilter/nf_conntrack_standalone.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2023-01-23 17:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 8:19 [PATCH] netfilter: conntrack: remote a return value of the 'seq_print_acct' function Gavrilov Ilia
2023-01-23 13:28 ` Leon Romanovsky
2023-01-23 14:06 ` Gavrilov Ilia
2023-01-23 14:31 ` [PATCH v2] " Gavrilov Ilia
2023-01-23 17:44 ` Leon Romanovsky [this message]
2023-02-01 11:17 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y87Hmv5qSZcD3rRZ@unreal \
--to=leon@kernel.org \
--cc=Ilia.Gavrilov@infotecs.ru \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=joe@perches.com \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).