From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 834F5C3DA78 for ; Tue, 17 Jan 2023 11:48:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235593AbjAQLsN (ORCPT ); Tue, 17 Jan 2023 06:48:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236788AbjAQLsM (ORCPT ); Tue, 17 Jan 2023 06:48:12 -0500 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B321F32E5A for ; Tue, 17 Jan 2023 03:48:11 -0800 (PST) Date: Tue, 17 Jan 2023 12:48:08 +0100 From: Pablo Neira Ayuso To: Sriram Yagnaraman Cc: netfilter-devel@vger.kernel.org, Florian Westphal , Marcelo Ricardo Leitner , Long Xin , Claudio Porfiri Subject: Re: [PATCH 2/3] netfilter: conntrack: fix bug in for_each_sctp_chunk Message-ID: References: <20230116093556.9437-1-sriram.yagnaraman@est.tech> <20230116093556.9437-3-sriram.yagnaraman@est.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230116093556.9437-3-sriram.yagnaraman@est.tech> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Mon, Jan 16, 2023 at 10:35:55AM +0100, Sriram Yagnaraman wrote: > skb_header_pointer() will return NULL if offset + sizeof(_sch) exceeds > skb->len, so this offset < skb->len test is redundant. > > if sch->length == 0, this will end up in an infinite loop, add a check > for sch->length > 0 If this is broken since the beginning, then: Fixes: 9fb9cbb1082d ("[NETFILTER]: Add nf_conntrack subsystem.") is sufficiently old for -stable kernels to pick up this. Let me know if this looks good to you, thanks