From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Alok Tiwari <alok.a.tiwari@oracle.com>
Cc: linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org,
darren.kenny@oracle.com
Subject: Re: [PATCH v2 6.1] netfilter: Null pointer dereference in nf_tables_updobj
Date: Tue, 17 Jan 2023 16:52:10 +0100 [thread overview]
Message-ID: <Y8bEKooxegoRSbkO@salvia> (raw)
In-Reply-To: <20230117154548.3403346-1-alok.a.tiwari@oracle.com>
On Tue, Jan 17, 2023 at 07:45:49AM -0800, Alok Tiwari wrote:
> static analyzer detect null pointer dereference case for 'type'
> function __nft_obj_type_get() can return NULL value which require to handle
> if type is NULL pointer return -ENOENT
Applied, thanks.
I have appended:
This should not ever happen, because if an object is found, then that
implies there is an object type, but let's add this as a failsafe check.
prev parent reply other threads:[~2023-01-17 15:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 15:45 [PATCH v2 6.1] netfilter: Null pointer dereference in nf_tables_updobj Alok Tiwari
2023-01-17 15:52 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8bEKooxegoRSbkO@salvia \
--to=pablo@netfilter.org \
--cc=alok.a.tiwari@oracle.com \
--cc=darren.kenny@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).