From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79EC0C3DA78 for ; Tue, 17 Jan 2023 15:53:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233680AbjAQPw6 (ORCPT ); Tue, 17 Jan 2023 10:52:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230465AbjAQPw2 (ORCPT ); Tue, 17 Jan 2023 10:52:28 -0500 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A4D2C22A08; Tue, 17 Jan 2023 07:52:13 -0800 (PST) Date: Tue, 17 Jan 2023 16:52:10 +0100 From: Pablo Neira Ayuso To: Alok Tiwari Cc: linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, darren.kenny@oracle.com Subject: Re: [PATCH v2 6.1] netfilter: Null pointer dereference in nf_tables_updobj Message-ID: References: <20230117154548.3403346-1-alok.a.tiwari@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230117154548.3403346-1-alok.a.tiwari@oracle.com> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Tue, Jan 17, 2023 at 07:45:49AM -0800, Alok Tiwari wrote: > static analyzer detect null pointer dereference case for 'type' > function __nft_obj_type_get() can return NULL value which require to handle > if type is NULL pointer return -ENOENT Applied, thanks. I have appended: This should not ever happen, because if an object is found, then that implies there is an object type, but let's add this as a failsafe check.