From: Jeremy Sowden <jeremy@azazel.net>
To: Jan Engelhardt <jengelh@inai.de>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Netfilter Devel <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH libnetfilter_log 0/6] Implementation of some fields omitted by `ipulog_get_packet`.
Date: Sat, 28 Aug 2021 23:19:00 +0100 [thread overview]
Message-ID: <YSq2VKWMsLvig5Ef@azazel.net> (raw)
In-Reply-To: <5n2q9rr7-p920-pro6-3nn2-pn5qps91so64@vanv.qr>
[-- Attachment #1: Type: text/plain, Size: 685 bytes --]
On 2021-08-28, at 21:53:19 +0200, Jan Engelhardt wrote:
> On Saturday 2021-08-28 21:38, Jeremy Sowden wrote:
> > Jeremy Sowden (6):
> > Add doxygen directory to .gitignore.
> > build: remove references to non-existent man-pages.
> > doc: fix typo's in example.
> > src: use calloc instead of malloc + memset.
> > libipulog: use correct index to find attribute in packet.
> > libipulog: fill in missing packet fields.
>
> Subjects are not full sentences, as such they should never contain
> trailing periods.
The ones above were certainly intended to be full sentences, but I see
that the kernel docuemntation talks about "summary phrases" in subjects,
so I take your point.
J.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-08-28 22:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-28 19:38 [PATCH libnetfilter_log 0/6] Implementation of some fields omitted by `ipulog_get_packet` Jeremy Sowden
2021-08-28 19:38 ` [PATCH libnetfilter_log 1/6] Add doxygen directory to .gitignore Jeremy Sowden
2021-08-28 19:38 ` [PATCH libnetfilter_log 2/6] build: remove references to non-existent man-pages Jeremy Sowden
2021-08-28 19:38 ` [PATCH libnetfilter_log 3/6] doc: fix typo's in example Jeremy Sowden
2021-08-28 19:38 ` [PATCH libnetfilter_log 4/6] src: use calloc instead of malloc + memset Jeremy Sowden
2021-08-28 19:38 ` [PATCH libnetfilter_log 5/6] libipulog: use correct index to find attribute in packet Jeremy Sowden
2021-08-28 19:38 ` [PATCH libnetfilter_log 6/6] libipulog: fill in missing packet fields Jeremy Sowden
2021-08-28 19:53 ` [PATCH libnetfilter_log 0/6] Implementation of some fields omitted by `ipulog_get_packet` Jan Engelhardt
2021-08-28 22:19 ` Jeremy Sowden [this message]
2021-08-30 0:16 ` Pablo Neira Ayuso
2021-08-30 1:33 ` Duncan Roe
2021-08-30 10:02 ` Jeremy Sowden
2021-08-31 9:00 ` Duncan Roe
2021-09-01 10:03 ` Jeremy Sowden
2021-08-30 10:05 ` Jeremy Sowden
2021-08-30 10:46 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSq2VKWMsLvig5Ef@azazel.net \
--to=jeremy@azazel.net \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).