From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: conntrack: fix boot failure with nf_conntrack.enable_hooks=1
Date: Tue, 28 Sep 2021 13:05:16 +0200 [thread overview]
Message-ID: <YVL27Ems+M8uhS5/@salvia> (raw)
In-Reply-To: <20210923144434.22531-1-fw@strlen.de>
On Thu, Sep 23, 2021 at 04:44:34PM +0200, Florian Westphal wrote:
> This is a revert of
> 7b1957b049 ("netfilter: nf_defrag_ipv4: use net_generic infra")
> and a partial revert of
> 8b0adbe3e3 ("netfilter: nf_defrag_ipv6: use net_generic infra").
>
> If conntrack is builtin and kernel is booted with:
> nf_conntrack.enable_hooks=1
>
> .... kernel will fail to boot due to a NULL deref in
> nf_defrag_ipv4_enable(): Its called before the ipv4 defrag initcall is
> made, so net_generic() returns NULL.
>
> To resolve this, move the user refcount back to struct net so calls
> to those functions are possible even before their initcalls have run.
Applied to nf, thanks.
prev parent reply other threads:[~2021-09-28 11:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 14:44 [PATCH nf] netfilter: conntrack: fix boot failure with nf_conntrack.enable_hooks=1 Florian Westphal
2021-09-28 11:05 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVL27Ems+M8uhS5/@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).