From: Jeremy Sowden <jeremy@azazel.net>
To: Netfilter Core Team <coreteam@netfilter.org>
Cc: Netfilter Devel <netfilter-devel@vger.kernel.org>,
Kyle Bowman <kbowman@cloudflare.com>,
Alex Forster <aforster@cloudflare.com>,
Cloudflare Kernel Team <kernel-team@cloudflare.com>
Subject: Re: [PATCH 1/3] extensions: libtxt_NFLOG: use nft built-in logging instead of xt_NFLOG
Date: Thu, 30 Sep 2021 21:04:20 +0100 [thread overview]
Message-ID: <YVYYRCDylFqmFlWC@azazel.net> (raw)
In-Reply-To: <YVVkN0ZNs5I+tKG+@azazel.net>
[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]
On 2021-09-30, at 08:16:07 +0100, Jeremy Sowden wrote:
> On 2021-08-09, at 14:42:41 -0500, Kyle Bowman wrote:
> > Replaces the use of xt_NFLOG with the nft built-in log statement.
> >
> > This additionally adds support for using longer log prefixes of 128
> > characters in size. Until now NFLOG has truncated the log-prefix to
> > the 64-character limit supported by iptables-legacy. We now use the
> > struct xtables_target's udata member to store the longer
> > 128-character prefix supported by iptables-nft.
> >
> > Signed-off-by: Kyle Bowman <kbowman@cloudflare.com>
> > Signed-off-by: Alex Forster <aforster@cloudflare.com>
> > Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
>
> Hi Core Team,
>
> It's been the better part of two months since this patch series was
> posted and there has been no feedback. I was wondering if one of you
> might be in a position to review it in the not too distant future. I
> see that it is delegated to Pablo in Patchwork, but then so is every-
> thing else. :)
Having asked for feedback, I've spotted a bug. :) Will fix and send out
v2.
J.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-09-30 20:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 19:42 [PATCH 1/3] extensions: libtxt_NFLOG: use nft built-in logging instead of xt_NFLOG Kyle Bowman
2021-08-09 19:42 ` [PATCH 2/3] extensions: libxt_NFLOG: dont truncate log prefix on print/save Kyle Bowman
2021-08-09 19:42 ` [PATCH 3/3] extensions: libxf_NFLOG: remove `--nflog-range` Python unit-tests Kyle Bowman
2021-09-30 7:16 ` [PATCH 1/3] extensions: libtxt_NFLOG: use nft built-in logging instead of xt_NFLOG Jeremy Sowden
2021-09-30 20:04 ` Jeremy Sowden [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVYYRCDylFqmFlWC@azazel.net \
--to=jeremy@azazel.net \
--cc=aforster@cloudflare.com \
--cc=coreteam@netfilter.org \
--cc=kbowman@cloudflare.com \
--cc=kernel-team@cloudflare.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).