From: Florian Westphal <fw@strlen.de>
To: Eugene Crosser <crosser@average.org>
Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
David Ahern <dsahern@gmail.com>,
Lahav Schlesinger <lschlesinger@drivenets.com>
Subject: Re: [PATCH net 1/1] vrf: Revert "Reset skb conntrack connection..."
Date: Wed, 20 Oct 2021 12:29:19 +0200 [thread overview]
Message-ID: <YW/vf/NoIChwT4KI@strlen.de> (raw)
In-Reply-To: <20211018182250.23093-2-crosser@average.org>
Eugene Crosser <crosser@average.org> wrote:
> This reverts commit 09e856d54bda5f288ef8437a90ab2b9b3eab83d1.
>
> When an interface is enslaved in a VRF, prerouting conntrack hook is
> called twice: once in the context of the original input interface, and
> once in the context of the VRF interface. If no special precausions are
> taken, this leads to creation of two conntrack entries instead of one,
> and breaks SNAT.
Fixes: 09e856d54bda5f ("vrf: Reset skb conntrack connection on VRF rcv")
Acked-by: Florian Westphal <fw@strlen.de>
prev parent reply other threads:[~2021-10-20 10:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 18:22 [PATCH net] vrf: Revert "Reset skb conntrack connection..." Eugene Crosser
2021-10-18 18:22 ` [PATCH net 1/1] " Eugene Crosser
2021-10-20 2:02 ` David Ahern
2021-10-20 10:29 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YW/vf/NoIChwT4KI@strlen.de \
--to=fw@strlen.de \
--cc=crosser@average.org \
--cc=dsahern@gmail.com \
--cc=lschlesinger@drivenets.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).