From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Mikhail Sennikovsky <mikhail.sennikovskii@ionos.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 2/2] conntrack: use same nfct handle for all entries
Date: Sun, 17 Oct 2021 15:58:45 +0200 [thread overview]
Message-ID: <YWwsFduko5Qtxidn@salvia> (raw)
In-Reply-To: <20210823155715.81729-3-mikhail.sennikovskii@ionos.com>
Hi Mikhail,
On Mon, Aug 23, 2021 at 05:57:15PM +0200, Mikhail Sennikovsky wrote:
> For bulk ct entry loads (with -R option) reusing the same nftc handle
> for all entries results in ~two-time reduction of entries creation
> time. This becomes signifficant when loading tens of thouthand of
> entries.
This is showing on of the limitations of the original API, I started
sketching a patch to update this code to use libmnl, I'd rather follow
this path.
Would you have the time to take it over and look into it?
> E.g. in the tests performed with the tests/conntrack/bulk-load-stress.sh
> the time used for loading of 131070 ct entries (2 * 0xffff)
> was 1.05s when this single nfct handle adjustment and 1.88s w/o it .
What is making things go faster? What is introduding the extra
overhead?
Thanks
prev parent reply other threads:[~2021-10-17 13:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 15:57 [PATCH 0/2] Reusing nfct handle for bulk ct loads Mikhail Sennikovsky
2021-08-23 15:57 ` [PATCH 1/2] tests/conntrack: script for stress-testing ct load Mikhail Sennikovsky
2021-09-06 10:48 ` Pablo Neira Ayuso
2021-08-23 15:57 ` [PATCH 2/2] conntrack: use same nfct handle for all entries Mikhail Sennikovsky
2021-10-17 13:58 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWwsFduko5Qtxidn@salvia \
--to=pablo@netfilter.org \
--cc=mikhail.sennikovskii@ionos.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).