Re: [PATCH nft] tests: run-tests.sh: ensure non-zero exit when $failed != 0

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Tue, Nov 02, 2021 at 09:31:15PM +0100, Phil Sutter wrote:
> Hi Pablo,
> 
> On Wed, Oct 27, 2021 at 11:09:23AM +0200, Pablo Neira Ayuso wrote:
> > On Wed, Oct 20, 2021 at 05:06:41PM +0200, Phil Sutter wrote:
> > > On Wed, Oct 20, 2021 at 02:44:09PM +0200, Štěpán Němec wrote:
> > > > POSIX [1] does not specify the behavior of `exit' with arguments
> > > > outside the 0-255 range, but what generally (bash, dash, zsh, OpenBSD
> > > > ksh, busybox) seems to happen is the shell exiting with status & 255
> > > > [2], which results in zero exit for certain non-zero arguments.
> > > 
> > > Standards aside, failed=256 is an actual bug:
> > > 
> > > | % bash -c "exit 255"; echo $?
> > > | 255
> > > | % bash -c "exit 256"; echo $?
> > > | 0
> > > | % bash -c "exit 257"; echo $?
> > > | 1
> > 
> > This is extra information you provided here for the commit message for
> > completion?
> 
> No need to extend the commit message IMO. I was just curious and played
> a bit with exit values in bash. So although unlikely, the unpatched code
> indeed confuses a result of 256 errors for a pass. :)

OK, then please go push out this patch if you're fine with it.