From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft 0/4] second batch of typeof fixes
Date: Thu, 9 Dec 2021 01:31:53 +0100 [thread overview]
Message-ID: <YbFOeQqyiSrzfejb@salvia> (raw)
In-Reply-To: <20211207151659.5507-1-fw@strlen.de>
On Tue, Dec 07, 2021 at 04:16:55PM +0100, Florian Westphal wrote:
> This series makes typeof-sets work in corner cases such as
>
> set s4 { typeof frag frag-off }
> set s8 { typeof ip version }
>
> frag frag-off @s4 accept
> ip version @s8
>
> Due to the shift/mask expressions needed to cope with these
> delinearization can't figure out the correct payload/exthdr templates
> and nft lists this as:
>
> (frag unknown & 0xfff8 [invalid type]) >> 3 == @s4
> (ip l4proto & pfsync) >> 4 == @s8
>
> With this series, the mask/shift expressions are removed and
> nft can print them in a readable way.
LGTM, thanks
prev parent reply other threads:[~2021-12-09 0:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 15:16 [PATCH nft 0/4] second batch of typeof fixes Florian Westphal
2021-12-07 15:16 ` [PATCH nft 1/4] tests: add shift+and typeof test cases Florian Westphal
2021-12-07 15:16 ` [PATCH nft 2/4] payload: skip templates with meta key set Florian Westphal
2021-12-07 15:16 ` [PATCH nft 3/4] netlink_delinearize: and/shift postprocessing Florian Westphal
2021-12-07 15:16 ` [PATCH nft 4/4] netlink_delinearize: zero shift removal Florian Westphal
2021-12-09 0:31 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbFOeQqyiSrzfejb@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox