From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jeremy Sowden <jeremy@azazel.net>
Cc: Netfilter Devel <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH] build: fix autoconf warnings
Date: Wed, 15 Dec 2021 22:51:51 +0100 [thread overview]
Message-ID: <Ybpjd2pO2LYMlrcy@salvia> (raw)
In-Reply-To: <20211215184440.39507-1-jeremy@azazel.net>
On Wed, Dec 15, 2021 at 06:44:40PM +0000, Jeremy Sowden wrote:
> autoconf complains about three obsolete macros.
>
> `AC_CONFIG_HEADER` has been superseded by `AC_CONFIG_HEADERS`, so
> replace it.
>
> `AM_PROG_LEX` calls `AC_PROG_LEX` with no arguments, but this usage is
> deprecated. The only difference between `AM_PROG_LEX` and `AC_PROG_LEX`
> is that the former defines `$LEX` as "./build-aux/missing lex" if no lex
> is found to ensure a useful error is reported when make is run. How-
> ever, the configure script checks that we have a working lex and exits
> with an error if none is available, so `$LEX` will never be called and
> we can replace `AM_PROG_LEX` with `AC_PROG_LEX`.
>
> `AM_PROG_LIBTOOL` has been superseded by `LT_INIT`, which is already in
> configure.ac, so remove it.
>
> We can also replace `AC_DISABLE_STATIC` with an argument to `LT_INIT`.
Also applied, thanks.
prev parent reply other threads:[~2021-12-15 21:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 18:44 [PATCH] build: fix autoconf warnings Jeremy Sowden
2021-12-15 18:47 ` Jeremy Sowden
2021-12-15 21:51 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ybpjd2pO2LYMlrcy@salvia \
--to=pablo@netfilter.org \
--cc=jeremy@azazel.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox