From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org, sbrivio@redhat.com,
etkaar <lists.netfilter.org@prvy.eu>
Subject: Re: [PATCH nf] netfilter: nft_set_pipapo: allocate pcpu scratch maps on clone
Date: Thu, 6 Jan 2022 10:41:04 +0100 [thread overview]
Message-ID: <Yda5MMa1KnH/WnEo@salvia> (raw)
In-Reply-To: <20220105131954.23666-1-fw@strlen.de>
On Wed, Jan 05, 2022 at 02:19:54PM +0100, Florian Westphal wrote:
> This is needed in case a new transaction is made that doesn't insert any
> new elements into an already existing set.
>
> Else, after second 'nft -f ruleset.txt', lookups in such a set will fail
> because ->lookup() encounters raw_cpu_ptr(m->scratch) == NULL.
>
> For the initial rule load, insertion of elements takes care of the
> allocation, but for rule reloads this isn't guaranteed: we might not
> have additions to the set.
Applied, thanks
prev parent reply other threads:[~2022-01-06 9:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 13:19 [PATCH nf] netfilter: nft_set_pipapo: allocate pcpu scratch maps on clone Florian Westphal
2022-01-05 15:20 ` Stefano Brivio
2022-01-06 9:41 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yda5MMa1KnH/WnEo@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=lists.netfilter.org@prvy.eu \
--cc=netfilter-devel@vger.kernel.org \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).