From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next] netfilter: egress: avoid a lockdep splat
Date: Sun, 9 Jan 2022 23:33:47 +0100 [thread overview]
Message-ID: <Ydtiy7AGGU6BxDmC@salvia> (raw)
In-Reply-To: <20220107144616.4261-1-fw@strlen.de>
On Fri, Jan 07, 2022 at 03:46:16PM +0100, Florian Westphal wrote:
> include/linux/netfilter_netdev.h:97 suspicious rcu_dereference_check() usage!
> 2 locks held by sd-resolve/1100:
> 0: ..(rcu_read_lock_bh){1:3}, at: ip_finish_output2
> 1: ..(rcu_read_lock_bh){1:3}, at: __dev_queue_xmit
> __dev_queue_xmit+0 ..
>
> The helper has two callers, one uses rcu_read_lock, the other
> rcu_read_lock_bh(). Annotate the dereference to reflect this.
Applied, thanks
prev parent reply other threads:[~2022-01-09 22:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 14:46 [PATCH nf-next] netfilter: egress: avoid a lockdep splat Florian Westphal
2022-01-09 22:33 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ydtiy7AGGU6BxDmC@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).