From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: Hangbin Liu <liuhangbin@gmail.com>,
netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
Florian Westphal <fw@strlen.de>
Subject: Re: [PATCH nf] selftests: netfilter: fix exit value for nft_concat_range
Date: Wed, 9 Feb 2022 11:08:37 +0100 [thread overview]
Message-ID: <YgOSpXdxuZ07zJH4@salvia> (raw)
In-Reply-To: <20220209105735.5cefed1d@elisabeth>
On Wed, Feb 09, 2022 at 10:57:35AM +0100, Stefano Brivio wrote:
> On Wed, 9 Feb 2022 16:25:51 +0800
> Hangbin Liu <liuhangbin@gmail.com> wrote:
>
> > When the nft_concat_range test failed, it exit 1 in the code
> > specifically.
> >
> > But when part of, or all of the test passed, it will failed the
> > [ ${passed} -eq 0 ] check and thus exit with 1, which is the same
> > exit value with failure result. Fix it by exit 0 when passed is not 0.
>
> Oops, right, thanks for fixing this!
>
> > Fixes: 611973c1e06f ("selftests: netfilter: Introduce tests for sets with range concatenation")
> > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
>
> Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
Applied, thanks
prev parent reply other threads:[~2022-02-09 10:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 8:25 [PATCH nf] selftests: netfilter: fix exit value for nft_concat_range Hangbin Liu
2022-02-09 9:57 ` Stefano Brivio
2022-02-09 10:08 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgOSpXdxuZ07zJH4@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).