* [PATCH nf] selftests: netfilter: fix exit value for nft_concat_range
@ 2022-02-09 8:25 Hangbin Liu
2022-02-09 9:57 ` Stefano Brivio
0 siblings, 1 reply; 3+ messages in thread
From: Hangbin Liu @ 2022-02-09 8:25 UTC (permalink / raw)
To: netdev
Cc: netfilter-devel, Pablo Neira Ayuso, Stefano Brivio,
Florian Westphal, Hangbin Liu
When the nft_concat_range test failed, it exit 1 in the code
specifically.
But when part of, or all of the test passed, it will failed the
[ ${passed} -eq 0 ] check and thus exit with 1, which is the same
exit value with failure result. Fix it by exit 0 when passed is not 0.
Fixes: 611973c1e06f ("selftests: netfilter: Introduce tests for sets with range concatenation")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
tools/testing/selftests/netfilter/nft_concat_range.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/netfilter/nft_concat_range.sh b/tools/testing/selftests/netfilter/nft_concat_range.sh
index df322e47a54f..b35010cc7f6a 100755
--- a/tools/testing/selftests/netfilter/nft_concat_range.sh
+++ b/tools/testing/selftests/netfilter/nft_concat_range.sh
@@ -1601,4 +1601,4 @@ for name in ${TESTS}; do
done
done
-[ ${passed} -eq 0 ] && exit ${KSELFTEST_SKIP}
+[ ${passed} -eq 0 ] && exit ${KSELFTEST_SKIP} || exit 0
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH nf] selftests: netfilter: fix exit value for nft_concat_range
2022-02-09 8:25 [PATCH nf] selftests: netfilter: fix exit value for nft_concat_range Hangbin Liu
@ 2022-02-09 9:57 ` Stefano Brivio
2022-02-09 10:08 ` Pablo Neira Ayuso
0 siblings, 1 reply; 3+ messages in thread
From: Stefano Brivio @ 2022-02-09 9:57 UTC (permalink / raw)
To: Hangbin Liu; +Cc: netdev, netfilter-devel, Pablo Neira Ayuso, Florian Westphal
On Wed, 9 Feb 2022 16:25:51 +0800
Hangbin Liu <liuhangbin@gmail.com> wrote:
> When the nft_concat_range test failed, it exit 1 in the code
> specifically.
>
> But when part of, or all of the test passed, it will failed the
> [ ${passed} -eq 0 ] check and thus exit with 1, which is the same
> exit value with failure result. Fix it by exit 0 when passed is not 0.
Oops, right, thanks for fixing this!
> Fixes: 611973c1e06f ("selftests: netfilter: Introduce tests for sets with range concatenation")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
--
Stefano
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH nf] selftests: netfilter: fix exit value for nft_concat_range
2022-02-09 9:57 ` Stefano Brivio
@ 2022-02-09 10:08 ` Pablo Neira Ayuso
0 siblings, 0 replies; 3+ messages in thread
From: Pablo Neira Ayuso @ 2022-02-09 10:08 UTC (permalink / raw)
To: Stefano Brivio; +Cc: Hangbin Liu, netdev, netfilter-devel, Florian Westphal
On Wed, Feb 09, 2022 at 10:57:35AM +0100, Stefano Brivio wrote:
> On Wed, 9 Feb 2022 16:25:51 +0800
> Hangbin Liu <liuhangbin@gmail.com> wrote:
>
> > When the nft_concat_range test failed, it exit 1 in the code
> > specifically.
> >
> > But when part of, or all of the test passed, it will failed the
> > [ ${passed} -eq 0 ] check and thus exit with 1, which is the same
> > exit value with failure result. Fix it by exit 0 when passed is not 0.
>
> Oops, right, thanks for fixing this!
>
> > Fixes: 611973c1e06f ("selftests: netfilter: Introduce tests for sets with range concatenation")
> > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
>
> Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-09 10:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-09 8:25 [PATCH nf] selftests: netfilter: fix exit value for nft_concat_range Hangbin Liu
2022-02-09 9:57 ` Stefano Brivio
2022-02-09 10:08 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).