From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [iptables PATCH] tests: iptables-test: Support variant deviation
Date: Wed, 9 Feb 2022 15:11:42 +0100 [thread overview]
Message-ID: <YgPLnk/AFfRhOADQ@salvia> (raw)
In-Reply-To: <20220204175520.29755-1-phil@nwl.cc>
On Fri, Feb 04, 2022 at 06:55:20PM +0100, Phil Sutter wrote:
> Some test results are not consistent between variants:
>
> * CLUSTERIP is not supported with nft_compat, so all related tests fail
> with iptables-nft.
> * iptables-legacy mandates TCPMSS be combined with SYN flag match,
> iptables-nft does not care. (Or precisely, xt_TCPMSS.ko can't validate
> match presence.)
>
> Avoid the expected failures by allowing "NFT" and "LGC" outcomes in
> addition to "OK" and "FAIL". They specify the variant with which given
> test should pass.
>
> Signed-off-by: Phil Sutter <phil@nwl.cc>
> ---
> extensions/libipt_CLUSTERIP.t | 4 ++--
> extensions/libxt_TCPMSS.t | 2 +-
> iptables-test.py | 7 +++++--
> 3 files changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/extensions/libipt_CLUSTERIP.t b/extensions/libipt_CLUSTERIP.t
> index 5af555e005c1d..d3a2d6cbb1b2e 100644
> --- a/extensions/libipt_CLUSTERIP.t
> +++ b/extensions/libipt_CLUSTERIP.t
> @@ -1,4 +1,4 @@
> :INPUT
> -d 10.31.3.236/32 -i lo -j CLUSTERIP --new --hashmode sourceip --clustermac 01:AA:7B:47:F7:D7 --total-nodes 2 --local-node 0 --hash-init 1;=;FAIL
> --d 10.31.3.236/32 -i lo -j CLUSTERIP --new --hashmode sourceip --clustermac 01:AA:7B:47:F7:D7 --total-nodes 2 --local-node 1 --hash-init 1;=;OK
Could you add a new semicolon to the test line instead?
--d 10.31.3.236/32 -i lo -j CLUSTERIP --new --hashmode sourceip --clustermac 01:AA:7B:47:F7:D7 --total-nodes 2 --local-node 1 --hash-init 1;=;OK;LEGACY
> --d 10.31.3.236/32 -i lo -j CLUSTERIP --new --hashmode sourceip --clustermac 01:AA:7B:47:F7:D7 --total-nodes 2 --local-node 2 --hash-init 1;=;OK
> +-d 10.31.3.236/32 -i lo -j CLUSTERIP --new --hashmode sourceip --clustermac 01:AA:7B:47:F7:D7 --total-nodes 2 --local-node 1 --hash-init 1;=;LGC
> +-d 10.31.3.236/32 -i lo -j CLUSTERIP --new --hashmode sourceip --clustermac 01:AA:7B:47:F7:D7 --total-nodes 2 --local-node 2 --hash-init 1;=;LGC
Thanks
next prev parent reply other threads:[~2022-02-09 14:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 17:55 [iptables PATCH] tests: iptables-test: Support variant deviation Phil Sutter
2022-02-09 14:11 ` Pablo Neira Ayuso [this message]
2022-02-09 14:22 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgPLnk/AFfRhOADQ@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).