From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [iptables PATCH v2] tests: iptables-test: Support variant deviation
Date: Thu, 10 Feb 2022 16:32:28 +0100 [thread overview]
Message-ID: <YgUwDLWCfCi1R1K/@salvia> (raw)
In-Reply-To: <20220209154107.25328-1-phil@nwl.cc>
On Wed, Feb 09, 2022 at 04:41:07PM +0100, Phil Sutter wrote:
> Some test results are not consistent between variants:
>
> * CLUSTERIP is not supported with nft_compat, so all related tests fail
> with iptables-nft.
> * iptables-legacy mandates TCPMSS be combined with SYN flag match,
> iptables-nft does not care. (Or precisely, xt_TCPMSS.ko can't validate
> match presence.)
>
> Introduce an optional fourth test spec field to specify the variant it
> applies to. Consequently, the opposite result is expected with the other
> variant.
LGTM, thanks
prev parent reply other threads:[~2022-02-10 15:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 15:41 [iptables PATCH v2] tests: iptables-test: Support variant deviation Phil Sutter
2022-02-10 15:32 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgUwDLWCfCi1R1K/@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).