From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6934C433EF for ; Thu, 10 Feb 2022 15:32:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239644AbiBJPcc (ORCPT ); Thu, 10 Feb 2022 10:32:32 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:60786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239590AbiBJPcb (ORCPT ); Thu, 10 Feb 2022 10:32:31 -0500 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 79969CE5 for ; Thu, 10 Feb 2022 07:32:31 -0800 (PST) Received: from netfilter.org (unknown [78.30.32.163]) by mail.netfilter.org (Postfix) with ESMTPSA id 5031C6019B; Thu, 10 Feb 2022 16:32:15 +0100 (CET) Date: Thu, 10 Feb 2022 16:32:28 +0100 From: Pablo Neira Ayuso To: Phil Sutter Cc: netfilter-devel@vger.kernel.org Subject: Re: [iptables PATCH v2] tests: iptables-test: Support variant deviation Message-ID: References: <20220209154107.25328-1-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220209154107.25328-1-phil@nwl.cc> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Wed, Feb 09, 2022 at 04:41:07PM +0100, Phil Sutter wrote: > Some test results are not consistent between variants: > > * CLUSTERIP is not supported with nft_compat, so all related tests fail > with iptables-nft. > * iptables-legacy mandates TCPMSS be combined with SYN flag match, > iptables-nft does not care. (Or precisely, xt_TCPMSS.ko can't validate > match presence.) > > Introduce an optional fourth test spec field to specify the variant it > applies to. Consequently, the opposite result is expected with the other > variant. LGTM, thanks