From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF91FC433EF for ; Sun, 20 Feb 2022 00:44:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234989AbiBTApG (ORCPT ); Sat, 19 Feb 2022 19:45:06 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:54514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243253AbiBTApG (ORCPT ); Sat, 19 Feb 2022 19:45:06 -0500 Received: from orbyte.nwl.cc (orbyte.nwl.cc [IPv6:2001:41d0:e:133a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4170856220 for ; Sat, 19 Feb 2022 16:44:46 -0800 (PST) Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.94.2) (envelope-from ) id 1nLaLE-0000Ry-EM; Sun, 20 Feb 2022 01:44:44 +0100 Date: Sun, 20 Feb 2022 01:44:44 +0100 From: Phil Sutter To: Pablo Neira Ayuso Cc: netfilter-devel@vger.kernel.org Subject: Re: [nft PATCH 03/26] scanner: Some time units are only used in limit scope Message-ID: Mail-Followup-To: Phil Sutter , Pablo Neira Ayuso , netfilter-devel@vger.kernel.org References: <20220219132814.30823-1-phil@nwl.cc> <20220219132814.30823-4-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Sun, Feb 20, 2022 at 01:38:19AM +0100, Pablo Neira Ayuso wrote: > On Sat, Feb 19, 2022 at 02:27:51PM +0100, Phil Sutter wrote: > > 'hour' and 'day' are allowed as unqualified meta expressions, so leave > > them alone. > > Are you use? I can see time_type is by 'ct expiration'. It's not about time_type, but the keywords. We support 'meta day' and 'meta hour' expressions, and they are allowed as unqualified. So effectively: | nft add rule t c day "Saturday" hour "13:37" must succeed. Therefore "day" and "hour" keywords must stay in global scope. Cheers, Phil