From: Dominique Martinet <asmadeus@codewreck.org>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, kuba@kernel.org
Subject: Re: [PATCH nf 2/5] netfilter: nf_tables_offload: incorrect flow offload action array size
Date: Tue, 22 Feb 2022 07:24:09 +0900 [thread overview]
Message-ID: <YhQRCVqtBfiHxChp@codewreck.org> (raw)
In-Reply-To: <20220221161757.250801-3-pablo@netfilter.org>
Pablo Neira Ayuso wrote on Mon, Feb 21, 2022 at 05:17:54PM +0100:
> immediate verdict expression needs to allocate one slot in the flow offload
> action array, however, immediate data expression does not need to do so.
>
> fwd and dup expression need to allocate one slot, this is missing.
>
> Add a new offload_action interface to report if this expression needs to
> allocate one slot in the flow offload action array.
>
> Fixes: be2861dc36d7 ("netfilter: nft_{fwd,dup}_netdev: add offload support")
> Reported-and-tested-by: Nick Gregory <Nick.Gregory@Sophos.com>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
FYI this patch has been reported as fixing an arbitrary oob write on
oss-security just now:
https://www.openwall.com/lists/oss-security/2022/02/21/2
So it might make sense to send it quickly to Linus and linux-stable for
immediate backport as it will get some attention...
The poster didn't say anything about coordinating this with security
handling people so it's safe to assume that wasn't done.
Thanks,
--
Dominique
next prev parent reply other threads:[~2022-02-21 22:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 16:17 [PATCH nf 0/5] Netfilter fixes for net Pablo Neira Ayuso
2022-02-21 16:17 ` [PATCH nf 1/5] netfilter: xt_socket: missing ifdef CONFIG_IP6_NF_IPTABLES dependency Pablo Neira Ayuso
2022-02-21 16:17 ` [PATCH nf 2/5] netfilter: nf_tables_offload: incorrect flow offload action array size Pablo Neira Ayuso
2022-02-21 22:24 ` Dominique Martinet [this message]
2022-02-21 16:17 ` [PATCH nf 3/5] netfilter: nf_tables: unregister flowtable hooks on netns exit Pablo Neira Ayuso
2022-02-21 16:17 ` [PATCH nf 4/5] netfilter: nft_limit: fix stateful object memory leak Pablo Neira Ayuso
2022-02-21 16:17 ` [PATCH nf 5/5] netfilter: nf_tables: fix memory leak during stateful obj update Pablo Neira Ayuso
2022-02-22 4:58 ` Jakub Kicinski
2022-02-22 6:57 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhQRCVqtBfiHxChp@codewreck.org \
--to=asmadeus@codewreck.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).