From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netfilter-devel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 64728C433F5
	for <netfilter-devel@archiver.kernel.org>; Tue, 22 Feb 2022 15:49:41 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229481AbiBVPuE (ORCPT
        <rfc822;netfilter-devel@archiver.kernel.org>);
        Tue, 22 Feb 2022 10:50:04 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39616 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S233587AbiBVPuD (ORCPT
        <rfc822;netfilter-devel@vger.kernel.org>);
        Tue, 22 Feb 2022 10:50:03 -0500
Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207])
        by lindbergh.monkeyblade.net (Postfix) with ESMTP id A74CA4617C
        for <netfilter-devel@vger.kernel.org>; Tue, 22 Feb 2022 07:49:38 -0800 (PST)
Received: from netfilter.org (unknown [78.30.32.163])
        by mail.netfilter.org (Postfix) with ESMTPSA id B45F26436A;
        Tue, 22 Feb 2022 16:48:37 +0100 (CET)
Date:   Tue, 22 Feb 2022 16:49:35 +0100
From:   Pablo Neira Ayuso <pablo@netfilter.org>
To:     Arturo Borrero Gonzalez <arturo@netfilter.org>
Cc:     netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: Re: [ANNOUNCE] nftables 1.0.2 release
Message-ID: <YhUGD5J1fMJ6FSN6@salvia>
References: <YhO5Pn+6+dgAgSd9@salvia>
 <7c75325e-f7c0-2354-3217-2735d8c3bbb6@netfilter.org>
 <YhUE38mgAKGV1WZn@salvia>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <YhUE38mgAKGV1WZn@salvia>
Precedence: bulk
List-ID: <netfilter-devel.vger.kernel.org>
X-Mailing-List: netfilter-devel@vger.kernel.org

On Tue, Feb 22, 2022 at 04:44:31PM +0100, Pablo Neira Ayuso wrote:
> On Tue, Feb 22, 2022 at 04:28:39PM +0100, Arturo Borrero Gonzalez wrote:
> > 
> > 
> > On 2/21/22 17:09, Pablo Neira Ayuso wrote:
> > > Hi!
> > > 
> > > The Netfilter project proudly presents:
> > > 
> > >          nftables 1.0.2
> > > 
> > 
> > 
> > Hi there,
> > 
> > this release doesn't build out of the box:
> > 
> > [..]
> > Making all in examples
> > make[3]: Entering directory '/<<PKGBUILDDIR>>/examples'
> > gcc -DHAVE_CONFIG_H -I. -I..   -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2
> > -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
> > -Werror=format-security -c -o nft-buffer.o nft-buffer.c
> > gcc -DHAVE_CONFIG_H -I. -I..   -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2
> > -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
> > -Werror=format-security -c -o nft-json-file.o nft-json-file.c
> > nft-json-file.c:3:10: fatal error: nftables/libnftables.h: No such file or
> > directory
> >     3 | #include <nftables/libnftables.h>
> >       |          ^~~~~~~~~~~~~~~~~~~~~~~~
> > compilation terminated.
> > nft-buffer.c:3:10: fatal error: nftables/libnftables.h: No such file or
> > directory
> >     3 | #include <nftables/libnftables.h>
> >       |          ^~~~~~~~~~~~~~~~~~~~~~~~
> > compilation terminated.
> > [..]
> > 
> > 
> > Some options:
> > * make the missing header file properly available to the example files
> > * don't build the examples unless explicitly requested, not as part of the
> > main program build
> > 
> > What do you suggest?
> 
> It is fixed here, both things you mentioned:
> 
> http://git.netfilter.org/nftables/commit/?id=18a08fb7f0443f8bde83393bd6f69e23a04246b3

Unfortunately, make distcheck did not catch this error since it uses
on libnftables local headers (my system already had previous version
headers).