From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH libnetfilter_queue] libnetfilter_queue: add support of skb->priority
Date: Wed, 23 Feb 2022 11:24:04 +0100 [thread overview]
Message-ID: <YhYLRLl9pJrdgsq1@salvia> (raw)
In-Reply-To: <e926bd60-7653-f528-ec15-2758a4ffc89a@6wind.com>
On Wed, Feb 23, 2022 at 10:01:48AM +0100, Nicolas Dichtel wrote:
>
> Le 04/02/2022 à 15:20, Pablo Neira Ayuso a écrit :
> > On Fri, Feb 04, 2022 at 01:01:26PM +0100, Florian Westphal wrote:
> >> Nicolas Dichtel <nicolas.dichtel@6wind.com> wrote:
> >>>
> >>> Le 04/02/2022 à 11:26, Nicolas Dichtel a écrit :
> >>>> Available since linux v5.18.
> >>>>
> >>>> Link: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=
> >>>> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> >>>> ---
> >>>
> >>> Should I send another patch for the 'set' part?
> >>> In this case, a nfq_set_verdict3(). The name is a bit ugly ;-)
> >>> Any suggestions?
> >>
> >> I think we should just let the old api die and tell users
> >> to use the mnl interface, that allows to add the new attribute
> >> as soon as its available.
> >
> > We have to provide a simple API based on mnl which ressembles the
> > existing old API.
> >
> > Feedback in these years is that there are a users that do not need to
> > know about netlink details / advanced handling.
>
> If I understand well, libnetfilter_queue is deprecated?
This library is not deprecated.
> If this is right, maybe it could be advertised on the project page:
> https://netfilter.org/projects/libnetfilter_queue/index.html
Documentation already mentions this:
https://netfilter.org/projects/libnetfilter_queue/doxygen/html/
next prev parent reply other threads:[~2022-02-23 10:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 20:56 [PATCH nf-next] nfqueue: enable to get skb->priority Nicolas Dichtel
2022-01-18 12:36 ` Florian Westphal
2022-02-04 5:15 ` Pablo Neira Ayuso
2022-02-04 5:16 ` Pablo Neira Ayuso
2022-02-04 10:21 ` [PATCH nf-next] nfqueue: enable to set skb->priority Nicolas Dichtel
2022-02-04 11:59 ` Florian Westphal
2022-02-04 17:18 ` kernel test robot
2022-02-09 11:04 ` Pablo Neira Ayuso
2022-02-04 10:26 ` [PATCH libnetfilter_queue] libnetfilter_queue: add support of skb->priority Nicolas Dichtel
2022-02-04 10:30 ` Nicolas Dichtel
2022-02-04 12:01 ` Florian Westphal
2022-02-04 14:20 ` Pablo Neira Ayuso
2022-02-23 9:01 ` Nicolas Dichtel
2022-02-23 10:24 ` Pablo Neira Ayuso [this message]
2022-02-23 14:03 ` Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhYLRLl9pJrdgsq1@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).