From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: nf_queue: don't assume sk is full socket
Date: Thu, 24 Feb 2022 15:58:33 +0100 [thread overview]
Message-ID: <YhedGbZ/1HfA498r@salvia> (raw)
In-Reply-To: <20220223201004.30615-1-fw@strlen.de>
On Wed, Feb 23, 2022 at 09:10:04PM +0100, Florian Westphal wrote:
> There is no guarantee that state->sk refers to a full socket.
>
> If refcount transitions to 0, sock_put calls sk_free which then ends up
> with garbage fields.
>
> I'd like to thank Oleksandr Natalenko and Jiri Benc for considerable
> debug work and pointing out state->sk oddities.
Applied, thanks
next prev parent reply other threads:[~2022-02-24 14:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 20:10 [PATCH nf] netfilter: nf_queue: don't assume sk is full socket Florian Westphal
2022-02-24 14:58 ` Pablo Neira Ayuso [this message]
2022-02-25 11:58 ` Oleksandr Natalenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhedGbZ/1HfA498r@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).