netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Sam James <sam@gentoo.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/2] libnftables.map: export new nft_ctx_{get,set}_optimize API
Date: Fri, 25 Feb 2022 00:37:58 +0100	[thread overview]
Message-ID: <YhgW1h1+TMhWsul4@salvia> (raw)
In-Reply-To: <20220224194543.59581-1-sam@gentoo.org>

On Thu, Feb 24, 2022 at 07:45:42PM +0000, Sam James wrote:
> Without this, we're not explicitly saying this is part of the public
> API.
> 
> This new API was added in 1.0.2 and is used by e.g. the main
> nft binary. Noticed when fixing the version-script option
> (separate patch) which picked up this problem when .map
> was missing symbols (related to when symbol visibility
> options get set).

Applied.

> Signed-off-by: Sam James <sam@gentoo.org>
> ---
>  src/libnftables.map | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/libnftables.map b/src/libnftables.map
> index a511dd78..f8cf05dc 100644
> --- a/src/libnftables.map
> +++ b/src/libnftables.map
> @@ -32,4 +32,6 @@ LIBNFTABLES_2 {
>  LIBNFTABLES_3 {
>    nft_set_optimize;
>    nft_get_optimize;

Removed the incorrect symbol name (missing _ctx_ infix)

> +  nft_ctx_set_optimize;
> +  nft_ctx_get_optimize;
>  } LIBNFTABLES_2;
> -- 
> 2.35.1
> 

      parent reply	other threads:[~2022-02-24 23:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-24 19:45 [PATCH 1/2] libnftables.map: export new nft_ctx_{get,set}_optimize API Sam James
2022-02-24 19:45 ` [PATCH 2/2] build: explicitly pass --version-script to linker Sam James
2022-02-24 23:38   ` Pablo Neira Ayuso
2022-02-24 21:39 ` [PATCH 1/2] libnftables.map: export new nft_ctx_{get,set}_optimize API Sam James
2022-02-24 21:46   ` Sam James
2022-02-24 23:37 ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YhgW1h1+TMhWsul4@salvia \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=sam@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).