From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 019BFC433EF for ; Thu, 24 Feb 2022 23:38:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233662AbiBXXic (ORCPT ); Thu, 24 Feb 2022 18:38:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232457AbiBXXic (ORCPT ); Thu, 24 Feb 2022 18:38:32 -0500 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 67CA618E3EE for ; Thu, 24 Feb 2022 15:38:01 -0800 (PST) Received: from netfilter.org (unknown [78.30.32.163]) by mail.netfilter.org (Postfix) with ESMTPSA id 6C73A6433D; Fri, 25 Feb 2022 00:36:51 +0100 (CET) Date: Fri, 25 Feb 2022 00:37:58 +0100 From: Pablo Neira Ayuso To: Sam James Cc: netfilter-devel@vger.kernel.org Subject: Re: [PATCH 1/2] libnftables.map: export new nft_ctx_{get,set}_optimize API Message-ID: References: <20220224194543.59581-1-sam@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220224194543.59581-1-sam@gentoo.org> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Thu, Feb 24, 2022 at 07:45:42PM +0000, Sam James wrote: > Without this, we're not explicitly saying this is part of the public > API. > > This new API was added in 1.0.2 and is used by e.g. the main > nft binary. Noticed when fixing the version-script option > (separate patch) which picked up this problem when .map > was missing symbols (related to when symbol visibility > options get set). Applied. > Signed-off-by: Sam James > --- > src/libnftables.map | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/libnftables.map b/src/libnftables.map > index a511dd78..f8cf05dc 100644 > --- a/src/libnftables.map > +++ b/src/libnftables.map > @@ -32,4 +32,6 @@ LIBNFTABLES_2 { > LIBNFTABLES_3 { > nft_set_optimize; > nft_get_optimize; Removed the incorrect symbol name (missing _ctx_ infix) > + nft_ctx_set_optimize; > + nft_ctx_get_optimize; > } LIBNFTABLES_2; > -- > 2.35.1 >