From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org, Karel Rericha <karel@maxtel.cz>,
Shmulik Ladkani <shmulik.ladkani@gmail.com>,
Eyal Birger <eyal.birger@gmail.com>
Subject: Re: [PATCH nf-next] netfilter: conntrack: revisit gc autotuning
Date: Sat, 19 Mar 2022 23:30:15 +0100 [thread overview]
Message-ID: <YjZZdylcRT41hFaf@salvia> (raw)
In-Reply-To: <20220216154305.30455-1-fw@strlen.de>
On Wed, Feb 16, 2022 at 04:43:05PM +0100, Florian Westphal wrote:
> as of commit 4608fdfc07e1
> ("netfilter: conntrack: collect all entries in one cycle")
> conntrack gc was changed to run every 2 minutes.
>
> On systems where conntrack hash table is set to large value, most evictions
> happen from gc worker rather than the packet path due to hash table
> distribution.
>
> This causes netlink event overflows when events are collected.
>
> This change collects average expiry of scanned entries and
> reschedules to the average remaining value, within 1 to 60 second interval.
>
> To avoid event overflows, reschedule after each bucket and add a
> limit for both run time and number of evictions per run.
>
> If more entries have to be evicted, reschedule and restart 1 jiffy
> into the future.
Applied, thanks.
prev parent reply other threads:[~2022-03-19 22:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 15:43 [PATCH nf-next] netfilter: conntrack: revisit gc autotuning Florian Westphal
2022-03-19 22:30 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjZZdylcRT41hFaf@salvia \
--to=pablo@netfilter.org \
--cc=eyal.birger@gmail.com \
--cc=fw@strlen.de \
--cc=karel@maxtel.cz \
--cc=netfilter-devel@vger.kernel.org \
--cc=shmulik.ladkani@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).