From: Phil Sutter <phil@nwl.cc>
To: Florian Westphal <fw@strlen.de>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>, netfilter-devel@vger.kernel.org
Subject: Re: [nf-next PATCH 2/2] netfilter: nf_log_syslog: Don't ignore unknown protocols
Date: Thu, 24 Mar 2022 15:34:49 +0100 [thread overview]
Message-ID: <YjyBiYbwhvUSqLJc@orbyte.nwl.cc> (raw)
In-Reply-To: <20220324141614.GC24666@breakpoint.cc>
On Thu, Mar 24, 2022 at 03:16:14PM +0100, Florian Westphal wrote:
> Phil Sutter <phil@nwl.cc> wrote:
> > With netdev and bridge nfprotos, loggers may see arbitrary ethernet
> > frames. Print at least basic info like interfaces and MAC header data.
>
> Makes sense to me.
>
> > + /* FIXME: Disabled from containers until syslog ns is supported */
> > + if (!net_eq(net, &init_net) && !sysctl_nf_log_all_netns)
> > + return;
>
> Hmm, this is now the 3rd incarnation of this comment + check,
> perhaps create another patch that adds a helper?
Yes, I thought about that already but found it not worth it. OTOH,
copying outdated comments is a sin so I'll submit a follow-up.
Thanks, Phil
next prev parent reply other threads:[~2022-03-24 14:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 14:03 [nf-next PATCH 1/2] netfilter: nf_log_syslog: Merge MAC header dumpers Phil Sutter
2022-03-24 14:03 ` [nf-next PATCH 2/2] netfilter: nf_log_syslog: Don't ignore unknown protocols Phil Sutter
2022-03-24 14:16 ` Florian Westphal
2022-03-24 14:34 ` Phil Sutter [this message]
2022-04-08 12:40 ` Pablo Neira Ayuso
2022-03-24 14:14 ` [nf-next PATCH 1/2] netfilter: nf_log_syslog: Merge MAC header dumpers Florian Westphal
2022-04-08 12:40 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjyBiYbwhvUSqLJc@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).