* [PATCH nf] ipvs: correctly print the memory size of ip_vs_conn_tab
@ 2022-04-12 9:00 Pengcheng Yang
2022-04-15 7:21 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Pengcheng Yang @ 2022-04-12 9:00 UTC (permalink / raw)
To: Simon Horman, Julian Anastasov, lvs-devel
Cc: Pablo Neira Ayuso, Jozsef Kadlecsik, Florian Westphal,
netfilter-devel, Pengcheng Yang
The memory size of ip_vs_conn_tab changed after we use hlist
instead of list.
Fixes: 731109e78415 ("ipvs: use hlist instead of list")
Signed-off-by: Pengcheng Yang <yangpc@wangsu.com>
---
net/netfilter/ipvs/ip_vs_conn.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/ipvs/ip_vs_conn.c b/net/netfilter/ipvs/ip_vs_conn.c
index 2c467c4..e886c74 100644
--- a/net/netfilter/ipvs/ip_vs_conn.c
+++ b/net/netfilter/ipvs/ip_vs_conn.c
@@ -1495,7 +1495,7 @@ int __init ip_vs_conn_init(void)
pr_info("Connection hash table configured "
"(size=%d, memory=%ldKbytes)\n",
ip_vs_conn_tab_size,
- (long)(ip_vs_conn_tab_size*sizeof(struct list_head))/1024);
+ (long)(ip_vs_conn_tab_size*sizeof(struct hlist_head))/1024);
IP_VS_DBG(0, "Each connection entry needs %zd bytes at least\n",
sizeof(struct ip_vs_conn));
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH nf] ipvs: correctly print the memory size of ip_vs_conn_tab
2022-04-12 9:00 [PATCH nf] ipvs: correctly print the memory size of ip_vs_conn_tab Pengcheng Yang
@ 2022-04-15 7:21 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2022-04-15 7:21 UTC (permalink / raw)
To: Pengcheng Yang
Cc: Julian Anastasov, lvs-devel, Pablo Neira Ayuso, Jozsef Kadlecsik,
Florian Westphal, netfilter-devel
On Tue, Apr 12, 2022 at 05:00:31PM +0800, Pengcheng Yang wrote:
> The memory size of ip_vs_conn_tab changed after we use hlist
> instead of list.
>
> Fixes: 731109e78415 ("ipvs: use hlist instead of list")
> Signed-off-by: Pengcheng Yang <yangpc@wangsu.com>
Acked-by: Simon Horman <horms@verge.net.au>
> ---
> net/netfilter/ipvs/ip_vs_conn.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/netfilter/ipvs/ip_vs_conn.c b/net/netfilter/ipvs/ip_vs_conn.c
> index 2c467c4..e886c74 100644
> --- a/net/netfilter/ipvs/ip_vs_conn.c
> +++ b/net/netfilter/ipvs/ip_vs_conn.c
> @@ -1495,7 +1495,7 @@ int __init ip_vs_conn_init(void)
> pr_info("Connection hash table configured "
> "(size=%d, memory=%ldKbytes)\n",
> ip_vs_conn_tab_size,
> - (long)(ip_vs_conn_tab_size*sizeof(struct list_head))/1024);
> + (long)(ip_vs_conn_tab_size*sizeof(struct hlist_head))/1024);
> IP_VS_DBG(0, "Each connection entry needs %zd bytes at least\n",
> sizeof(struct ip_vs_conn));
>
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-15 7:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-12 9:00 [PATCH nf] ipvs: correctly print the memory size of ip_vs_conn_tab Pengcheng Yang
2022-04-15 7:21 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).