From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>
Cc: netdev@vger.kernel.org, Taras Chornyi <taras.chornyi@plvision.eu>,
Serhiy Pshyk <serhiy.pshyk@plvision.eu>,
Oz Shlomo <ozsh@nvidia.com>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Florian Westphal <fw@strlen.de>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Paul Blakey <paulb@nvidia.com>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] netfilter: conn: fix udp offload timeout sysctl
Date: Wed, 27 Apr 2022 15:49:36 +0200 [thread overview]
Message-ID: <YmlJ8Oa1mjwUHpfl@salvia> (raw)
In-Reply-To: <1651057740-12713-1-git-send-email-volodymyr.mytnyk@plvision.eu>
On Wed, Apr 27, 2022 at 02:09:00PM +0300, Volodymyr Mytnyk wrote:
> `nf_flowtable_udp_timeout` sysctl option is available only
> if CONFIG_NFT_FLOW_OFFLOAD enabled. But infra for this flow
> offload UDP timeout was added under CONFIG_NF_FLOW_TABLE
> config option. So, if you have CONFIG_NFT_FLOW_OFFLOAD
> disabled and CONFIG_NF_FLOW_TABLE enabled, the
> `nf_flowtable_udp_timeout` is not present in sysfs.
> Please note, that TCP flow offload timeout sysctl option
> is present even CONFIG_NFT_FLOW_OFFLOAD is disabled.
>
> I suppose it was a typo in commit that adds UDP flow offload
> timeout and CONFIG_NF_FLOW_TABLE should be used instead.
Applied, thanks
prev parent reply other threads:[~2022-04-27 13:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 11:09 [PATCH net] netfilter: conn: fix udp offload timeout sysctl Volodymyr Mytnyk
2022-04-27 13:49 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmlJ8Oa1mjwUHpfl@salvia \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=ozsh@nvidia.com \
--cc=pabeni@redhat.com \
--cc=paulb@nvidia.com \
--cc=serhiy.pshyk@plvision.eu \
--cc=taras.chornyi@plvision.eu \
--cc=volodymyr.mytnyk@plvision.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).