From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org, Topi Miettinen <toiwoton@gmail.com>
Subject: Re: [PATCH v2 nf] netfilter: nft_socket: only do sk lookups when indev is available
Date: Thu, 28 Apr 2022 16:15:17 +0200 [thread overview]
Message-ID: <YmqhdQjqndZXVee8@salvia> (raw)
In-Reply-To: <20220428073921.14483-1-fw@strlen.de>
On Thu, Apr 28, 2022 at 09:39:21AM +0200, Florian Westphal wrote:
> Check if the incoming interface is available and NFT_BREAK
> in case neither skb->sk nor input device are set.
>
> Because nf_sk_lookup_slow*() assume packet headers are in the
> 'in' direction, use in postrouting is not going to yield a meaningful
> result. Same is true for the forward chain, so restrict the use
> to prerouting, input and output.
>
> Use in output work if a socket is already attached to the skb.
Applied to nf.git, thanks
prev parent reply other threads:[~2022-04-28 14:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 7:39 [PATCH v2 nf] netfilter: nft_socket: only do sk lookups when indev is available Florian Westphal
2022-04-28 14:15 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmqhdQjqndZXVee8@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=toiwoton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).