From: Phil Sutter <phil@nwl.cc>
To: Nick Hainke <vincent@systemli.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH iptables 2/2] xshared: fix compilation with musl
Date: Sat, 14 May 2022 19:09:59 +0200 [thread overview]
Message-ID: <Yn/iZyTrZvj++6ZA@orbyte.nwl.cc> (raw)
In-Reply-To: <20220514163325.54266-2-vincent@systemli.org>
On Sat, May 14, 2022 at 06:33:25PM +0200, Nick Hainke wrote:
> Gcc complains about missing types. Include <sys/types.h> to fix it.
>
> Fixes errors in the form of:
> In file included from xtables-legacy-multi.c:5:
> xshared.h:83:56: error: unknown type name 'u_int16_t'; did you mean 'uint16_t'?
> 83 | set_option(unsigned int *options, unsigned int option, u_int16_t *invflg,
> | ^~~~~~~~~
> | uint16_t
> make[6]: *** [Makefile:712: xtables_legacy_multi-xtables-legacy-multi.o] Error 1
Does it work if you change the type to uint16_t instead? This looks like
fixing for a typo in f647f61f273a1 ("xtables: Make invflags 16bit wide")
which I didn't notice.
Thanks, Phil
next prev parent reply other threads:[~2022-05-14 17:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-14 16:33 [PATCH iptables 1/2] xtables: fix compilation with musl Nick Hainke
2022-05-14 16:33 ` [PATCH iptables 2/2] xshared: " Nick Hainke
2022-05-14 17:09 ` Phil Sutter [this message]
2022-05-16 6:47 ` [PATCH] treewide: use uint* instead of u_int* vincent
2022-05-16 10:28 ` Jan Engelhardt
2022-05-16 16:16 ` vincent
2022-05-17 8:10 ` Phil Sutter
2022-05-17 8:14 ` Jan Engelhardt
2022-05-18 13:21 ` Phil Sutter
2022-05-31 21:32 ` Nick
2022-05-14 17:04 ` [PATCH iptables 1/2] xtables: fix compilation with musl Phil Sutter
2022-05-14 19:14 ` Maciej Żenczykowski
2022-05-15 12:05 ` Phil Sutter
2022-05-15 13:40 ` Maciej Żenczykowski
2022-05-17 8:17 ` Phil Sutter
2022-05-17 8:22 ` Maciej Żenczykowski
2022-05-15 14:09 ` Florian Westphal
2022-05-15 14:13 ` Maciej Żenczykowski
2022-05-17 8:14 ` Phil Sutter
2022-05-16 6:52 ` Nick
2022-05-16 7:12 ` Maciej Żenczykowski
2022-05-16 16:24 ` [PATCH] " vincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yn/iZyTrZvj++6ZA@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=vincent@systemli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).