From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C7C5C433F5 for ; Sun, 15 May 2022 12:16:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233800AbiEOMQj (ORCPT ); Sun, 15 May 2022 08:16:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232000AbiEOMQi (ORCPT ); Sun, 15 May 2022 08:16:38 -0400 Received: from orbyte.nwl.cc (orbyte.nwl.cc [IPv6:2001:41d0:e:133a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C84BEDF for ; Sun, 15 May 2022 05:16:36 -0700 (PDT) Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.94.2) (envelope-from ) id 1nqDAp-0000DI-21; Sun, 15 May 2022 14:16:35 +0200 Date: Sun, 15 May 2022 14:16:35 +0200 From: Phil Sutter To: Pablo Neira Ayuso Cc: netfilter-devel@vger.kernel.org Subject: Re: [PATCH libnftnl] src: add dynamic register allocation infrastructure Message-ID: Mail-Followup-To: Phil Sutter , Pablo Neira Ayuso , netfilter-devel@vger.kernel.org References: <20220502110744.113720-1-pablo@netfilter.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Sun, May 15, 2022 at 12:29:44AM +0200, Pablo Neira Ayuso wrote: > On Sat, May 14, 2022 at 06:49:35PM +0200, Phil Sutter wrote: > > On Mon, May 02, 2022 at 01:07:44PM +0200, Pablo Neira Ayuso wrote: > > > Starting Linux kernel 5.18-rc, operations on registers that already > > > contain the expected data are turned into noop. > > > > > > Track operation on registers to use the same register through > > > nftnl_reg_get(). This patch introduces an LRU eviction strategy when all > > > the registers are in used. > > > > > > nftnl_reg_get_scratch() is used to allocate a register as scratchpad > > > area: no tracking is performed in this case, although register eviction > > > might occur. > > > > > > Signed-off-by: Pablo Neira Ayuso > > > --- > > > include/expr_ops.h | 6 + > > > include/internal.h | 1 + > > > include/libnftnl/Makefile.am | 1 + > > > include/regs.h | 32 ++++++ > > > src/Makefile.am | 1 + > > > src/expr/meta.c | 44 +++++++ > > > src/expr/payload.c | 31 +++++ > > > src/libnftnl.map | 7 ++ > > > src/regs.c | 216 +++++++++++++++++++++++++++++++++++ > > > 9 files changed, 339 insertions(+) > > > create mode 100644 include/regs.h > > > create mode 100644 src/regs.c > > > > Did you forget to add include/libnftnl/regs.h to this patch? It is > > referenced from src/regs.c and build fails. > > Yes, this is fixed here: > > http://git.netfilter.org/libnftnl/commit/?id=e549f5b3239c19f78af2f7c7a582fe5616403ca8 Thanks for the quick fix! Cheers, Phil