From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE6C2C4332F for ; Thu, 19 May 2022 20:40:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244473AbiESUkP (ORCPT ); Thu, 19 May 2022 16:40:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234992AbiESUkP (ORCPT ); Thu, 19 May 2022 16:40:15 -0400 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2C83B98597 for ; Thu, 19 May 2022 13:40:11 -0700 (PDT) Date: Thu, 19 May 2022 22:40:07 +0200 From: Pablo Neira Ayuso To: Florian Westphal Cc: netfilter-devel@vger.kernel.org, syzbot+92968395eedbdbd3617d@syzkaller.appspotmail.com Subject: Re: [PATCH nf-next] netfilter: cttimeout: fix slab-out-of-bounds read in cttimeout_net_exit Message-ID: References: <0000000000002ecf9805df3af808@google.com> <20220517205036.25883-1-fw@strlen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220517205036.25883-1-fw@strlen.de> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Tue, May 17, 2022 at 10:50:36PM +0200, Florian Westphal wrote: > syzbot reports: > BUG: KASAN: slab-out-of-bounds in __list_del_entry_valid+0xcc/0xf0 lib/list_debug.c:42 > [..] > list_del include/linux/list.h:148 [inline] > cttimeout_net_exit+0x211/0x540 net/netfilter/nfnetlink_cttimeout.c:617 > > No reproducer so far. Looking at recent changes in this area > its clear that the free_head must not be at the end of the > structure because nf_ct_timeout structure has variable size. Applied, thanks