From: Phil Sutter <phil@nwl.cc>
To: Nick <vincent@systemli.org>
Cc: netfilter-devel@vger.kernel.org,
Pablo Neira Ayuso <pablo@netfilter.org>,
Jan Engelhardt <jengelh@inai.de>
Subject: Re: [PATCH] Revert "Simplify static build extension loading"
Date: Wed, 1 Jun 2022 19:14:49 +0200 [thread overview]
Message-ID: <YpeeibvCnRYeifhF@orbyte.nwl.cc> (raw)
In-Reply-To: <1678505c-aa11-6fcf-87b4-eeaa0113af62@systemli.org>
On Wed, Jun 01, 2022 at 04:22:49PM +0200, Nick wrote:
> More Information:
> https://github.com/openwrt/openwrt/pull/9886#issuecomment-1143191713
>
> I have to debug further.
Well, it looks like firewall3 does a static build and calls
init_extensions*(). It includes xtables.h without defining ALL_INCLUSIVE
or NO_SHARED_LIBS, so ends up with the empty function definitions.
Given that these functions are for internal use only, it is only harmful
to declare them in the "official" libxtables header.
Unless someone objects, I'll prepare a patch moving the declarations
into xshared.h.
Cheers, Phil
prev parent reply other threads:[~2022-06-01 17:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 13:47 [PATCH] Revert "Simplify static build extension loading" Nick Hainke
2022-06-01 13:53 ` Phil Sutter
2022-06-01 14:22 ` Nick
2022-06-01 17:05 ` Jan Engelhardt
2022-06-01 17:14 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YpeeibvCnRYeifhF@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=vincent@systemli.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).