Re: [PATCH 5/6] tests/conntrack: ct -o save for unknown protocols

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Thu, Jun 23, 2022 at 07:49:59PM +0200, Mikhail Sennikovsky wrote:
> Testcases covering dumping in -o save formate of ct entries of
> L4 protocols unknown to the conntrack tool,
> which does not work properly at the moment.
> Fix included in the next commit.

Could you collapse the test to the relevant patch (next commit as
description suggests)? I find this easier to find when looking at git
annotate.

> Signed-off-by: Mikhail Sennikovsky <mikhail.sennikovskii@ionos.com>
> ---
>  tests/conntrack/testsuite/09dumpopt | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/tests/conntrack/testsuite/09dumpopt b/tests/conntrack/testsuite/09dumpopt
> index 447590b..c1e0e6e 100644
> --- a/tests/conntrack/testsuite/09dumpopt
> +++ b/tests/conntrack/testsuite/09dumpopt
> @@ -145,3 +145,29 @@
>  -D -w 11 -u SEEN_REPLY -s 1.1.1.1 -d 2.2.2.2 -r 2.2.2.2 -q 1.1.1.1 -p icmp --icmp-type 8 --icmp-code 0 --icmp-id 1226 ; OK
>  # clean up after yourself
>  -D -w 10 ; OK
> +# Cover protocols unknown to the conntrack tool
> +# Create a conntrack entries
> +# IGMP
> +-I -w 10 -t 59 -s 0.0.0.0 -d 224.0.0.22 -r 224.0.0.22 -q 0.0.0.0 -p 2 ;
> +# Some fency protocol
> +-I -w 10 -t 59 -s 0.0.0.0 -d 224.0.0.22 -r 224.0.0.22 -q 0.0.0.0 -p 200 ;
> +# Some fency protocol with IPv6
> +-I -w 10 -t 59 -s 2001:DB8::1.1.1.1 -d 2001:DB8::2.2.2.2 -p 200 ;
> +-R - ; OK
> +# copy to zone 11
> +-L -w 10 -o save ; |s/-w 10/-w 11/g
> +-R - ; OK
> +# Delete stuff in zone 10, should succeed
> +# IGMP
> +-D -w 10 -s 0.0.0.0 -d 224.0.0.22 -r 224.0.0.22 -q 0.0.0.0 -p 2 ; OK
> +# Some fency protocol
> +-D -w 10  -s 0.0.0.0 -d 224.0.0.22 -r 224.0.0.22 -q 0.0.0.0 -p 200 ; OK
> +# Some fency protocol with IPv6
> +-D -w 10 -s 2001:DB8::1.1.1.1 -d 2001:DB8::2.2.2.2 -p 200 ; OK
> +# Delete stuff in zone 11, should succeed
> +# IGMP
> +-D -w 11 -s 0.0.0.0 -d 224.0.0.22 -r 224.0.0.22 -q 0.0.0.0 -p 2 ; OK
> +# Some fency protocol
> +-D -w 11  -s 0.0.0.0 -d 224.0.0.22 -r 224.0.0.22 -q 0.0.0.0 -p 200 ; OK
> +# Some fency protocol with IPv6
> +-D -w 11 -s 2001:DB8::1.1.1.1 -d 2001:DB8::2.2.2.2 -p 200 ; OK
> -- 
> 2.25.1
>