From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F302C433EF for ; Thu, 23 Jun 2022 15:59:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231245AbiFWP7z (ORCPT ); Thu, 23 Jun 2022 11:59:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230234AbiFWP7z (ORCPT ); Thu, 23 Jun 2022 11:59:55 -0400 Received: from orbyte.nwl.cc (orbyte.nwl.cc [IPv6:2001:41d0:e:133a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8502037A9E for ; Thu, 23 Jun 2022 08:59:54 -0700 (PDT) Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.94.2) (envelope-from ) id 1o4PFI-0008GC-Us; Thu, 23 Jun 2022 17:59:52 +0200 Date: Thu, 23 Jun 2022 17:59:52 +0200 From: Phil Sutter To: Pablo Neira Ayuso Cc: netfilter-devel@vger.kernel.org Subject: Re: [PATCH nft] tests: shell: large set overlap and automerge Message-ID: Mail-Followup-To: Phil Sutter , Pablo Neira Ayuso , netfilter-devel@vger.kernel.org References: <20220616093541.277164-1-pablo@netfilter.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220616093541.277164-1-pablo@netfilter.org> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Thu, Jun 16, 2022 at 11:35:41AM +0200, Pablo Neira Ayuso wrote: > Add a test to validate set overlap and automerge for large set. This > test runs nft -f twice to cover for set reload without flush. I had this in mind as well, but didn't like to hard-code any thresholds. Your test is useful only for manual result review and will always pass, therefore will only increase testsuite run time without any benefit. Cheers, Phil