From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] parser_bison: bail out on too long names
Date: Mon, 18 Jul 2022 15:15:05 +0200 [thread overview]
Message-ID: <YtVc2axPCJwADuNM@orbyte.nwl.cc> (raw)
In-Reply-To: <YtVEzsOM4VxFW4An@salvia>
On Mon, Jul 18, 2022 at 01:32:30PM +0200, Pablo Neira Ayuso wrote:
> On Sat, Jul 16, 2022 at 01:56:28PM +0200, Phil Sutter wrote:
> > Hi,
> >
> > On Sat, Jul 16, 2022 at 10:05:49AM +0200, Pablo Neira Ayuso wrote:
> > > If user specifies a too long object name, bail out.
> >
> > Shouldn't this be done in eval phase or so? As-is, this patch introduces
> > a standard syntax-specific limitation people may circumvent using JSON,
> > no?
>
> I can do it from eval phase. I will have to add more eval functions
> though, because eval is not always called from for every command.
All I'm saying is we shouldn't divert in between the two parsers. Why is
limiting the max name length required, BTW?
Cheers, Phil
next prev parent reply other threads:[~2022-07-18 13:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-16 8:05 [PATCH nft] parser_bison: bail out on too long names Pablo Neira Ayuso
2022-07-16 11:56 ` Phil Sutter
2022-07-18 11:32 ` Pablo Neira Ayuso
2022-07-18 13:15 ` Phil Sutter [this message]
2022-07-18 14:32 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtVc2axPCJwADuNM@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).