From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43B7AC04A95 for ; Wed, 28 Sep 2022 18:05:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234586AbiI1SF5 (ORCPT ); Wed, 28 Sep 2022 14:05:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234550AbiI1SFy (ORCPT ); Wed, 28 Sep 2022 14:05:54 -0400 Received: from orbyte.nwl.cc (orbyte.nwl.cc [IPv6:2001:41d0:e:133a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5CE9101961 for ; Wed, 28 Sep 2022 11:05:51 -0700 (PDT) Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.94.2) (envelope-from ) id 1odbRM-0002gP-95; Wed, 28 Sep 2022 20:05:48 +0200 Date: Wed, 28 Sep 2022 20:05:48 +0200 From: Phil Sutter To: Florian Westphal Cc: Florian Westphal , netfilter-devel@vger.kernel.org Subject: Re: [iptables PATCH] nft: Fix meta statement parsing Message-ID: Mail-Followup-To: Phil Sutter , Florian Westphal , Florian Westphal , netfilter-devel@vger.kernel.org References: <20220928162300.1055-1-phil@nwl.cc> <20220928175723.GN12777@breakpoint.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220928175723.GN12777@breakpoint.cc> Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Wed, Sep 28, 2022 at 07:57:23PM +0200, Florian Westphal wrote: > Phil Sutter wrote: > > The function nft_meta_set_to_target() would always bail since nothing > > sets 'sreg->meta_sreg.set' to true. This is obvious, as the immediate > > expression "filling" the source register does not indicate its purpose. > > Hmm, is there a missing test case? I did not see any failures. extensions/libxt_TRACE.t was failing if I called iptables-test.py with '-n' option. > > The whole source register purpose storing in meta_sreg seems to be > > pointless, so drop it altogether. > > Yes; from iptables perspective a 'meta set' operation has to be mapped > to a target, so there is no need to store this for subsequent > consumption. OK, cool. I'll push this all upstream now. :) Thanks, Phil