netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH] monitor: Sanitize startup race condition
Date: Fri, 30 Sep 2022 16:04:06 +0200	[thread overview]
Message-ID: <Yzb3Vj7/GpyL7hRf@orbyte.nwl.cc> (raw)
In-Reply-To: <Yzbr2l+oH6ilq2l0@salvia>

Hi,

On Fri, Sep 30, 2022 at 03:15:06PM +0200, Pablo Neira Ayuso wrote:
[...]
> Fine to apply this meanwhile.

Thanks. I tried to find a better solution, but failed. IMO it should be
enough to just refresh cache from scratch once the first event is
received, but it seems the reproducer script is too aggressive even for
that.

> I wanted to fix this, but I found a few kernel bugs at that time, such as:
> 
> commit 6fb721cf781808ee2ca5e737fb0592cc68de3381
> Author: Pablo Neira Ayuso <pablo@netfilter.org>
> Date:   Sun Sep 26 09:59:35 2021 +0200
> 
>     netfilter: nf_tables: honor NLM_F_CREATE and NLM_F_EXCL in event notification
> 
> which were not allowing me to infer the location accordingly, for
> incrementally updating the cache.
> 
> So I stopped for a while until these fixes propagate to the kernel.
> 
> It's been 1 year even since, times flies...

Same here. My backlog just keeps growing and with it the number of
side-projects "to get back to later".

Cheers, Phil

      reply	other threads:[~2022-09-30 14:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-28 22:32 [nft PATCH] monitor: Sanitize startup race condition Phil Sutter
2022-09-30 13:15 ` Pablo Neira Ayuso
2022-09-30 14:04   ` Phil Sutter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yzb3Vj7/GpyL7hRf@orbyte.nwl.cc \
    --to=phil@nwl.cc \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).