Re: [net-next v3 1/3] netfilter: replace select by depends on for IP{6}_NF_IPTABLES_LEGACY

[Phil Sutter <phil@nwl.cc>]

Hi Bigeasy!

On Tue, Mar 25, 2025 at 05:58:30PM +0100, Sebastian Andrzej Siewior wrote:
> From: Pablo Neira Ayuso <pablo@netfilter.org>
> 
> Relax dependencies on iptables legacy, replace select by depends on,
> this should cause no harm to existing kernel configs and users can still
> toggle IP{6}_NF_IPTABLES_LEGACY in any case.
> 
> [fw: Replace depends on BRIDGE_NF_EBTABLES_LEGACY with select]

I don't get this remark: The three chunks dealing with that symbol do
the opposite, namely replacing 'select ...' with 'depends on ...'. Do I
miss the point or is this a leftover?

> diff --git a/net/bridge/netfilter/Kconfig b/net/bridge/netfilter/Kconfig
> index f16bbbbb94817..a6770845d3aba 100644
> --- a/net/bridge/netfilter/Kconfig
> +++ b/net/bridge/netfilter/Kconfig
> @@ -65,7 +65,7 @@ if BRIDGE_NF_EBTABLES
>  #
>  config BRIDGE_EBT_BROUTE
>  	tristate "ebt: broute table support"
> -	select BRIDGE_NF_EBTABLES_LEGACY
> +	depends on BRIDGE_NF_EBTABLES_LEGACY
>  	help
>  	  The ebtables broute table is used to define rules that decide between
>  	  bridging and routing frames, giving Linux the functionality of a
> @@ -76,7 +76,7 @@ config BRIDGE_EBT_BROUTE
>  
>  config BRIDGE_EBT_T_FILTER
>  	tristate "ebt: filter table support"
> -	select BRIDGE_NF_EBTABLES_LEGACY
> +	depends on BRIDGE_NF_EBTABLES_LEGACY
>  	help
>  	  The ebtables filter table is used to define frame filtering rules at
>  	  local input, forwarding and local output. See the man page for
> @@ -86,7 +86,7 @@ config BRIDGE_EBT_T_FILTER
>  
>  config BRIDGE_EBT_T_NAT
>  	tristate "ebt: nat table support"
> -	select BRIDGE_NF_EBTABLES_LEGACY
> +	depends on BRIDGE_NF_EBTABLES_LEGACY
>  	help
>  	  The ebtables nat table is used to define rules that alter the MAC
>  	  source address (MAC SNAT) or the MAC destination address (MAC DNAT).

Cheers, Phil