* [nft PATCH] tests: shell: Fix owner/0002-persist on aarch64
@ 2025-03-28 14:09 Phil Sutter
2025-03-28 14:33 ` Florian Westphal
0 siblings, 1 reply; 3+ messages in thread
From: Phil Sutter @ 2025-03-28 14:09 UTC (permalink / raw)
To: Pablo Neira Ayuso; +Cc: netfilter-devel
Not sure if arch-specific, but for some reason src/nft wrapper script
would call src/.libs/lt-nft and thus the owner appeared as 'lt-nft'
instead of the expected 'nft'. Cover for that by extracting the expected
program name from /proc.
Fixes: b5205165bd708 ("tests: shell: Extend table persist flag test a bit")
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
tests/shell/testcases/owner/0002-persist | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/shell/testcases/owner/0002-persist b/tests/shell/testcases/owner/0002-persist
index 98a8eb1368bc1..700f00ec5e5f1 100755
--- a/tests/shell/testcases/owner/0002-persist
+++ b/tests/shell/testcases/owner/0002-persist
@@ -47,7 +47,8 @@ cat >&"${COPROC[1]}" <<EOF
add table ip t { flags owner, persist; }
EOF
-EXPECT="table ip t { # progname nft
+COMM=$(</proc/${COPROC_PID}/comm)
+EXPECT="table ip t { # progname $COMM
flags owner,persist
}"
diff -u <(echo "$EXPECT") <($NFT list ruleset) || {
--
2.48.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [nft PATCH] tests: shell: Fix owner/0002-persist on aarch64
2025-03-28 14:09 [nft PATCH] tests: shell: Fix owner/0002-persist on aarch64 Phil Sutter
@ 2025-03-28 14:33 ` Florian Westphal
2025-03-28 15:47 ` Phil Sutter
0 siblings, 1 reply; 3+ messages in thread
From: Florian Westphal @ 2025-03-28 14:33 UTC (permalink / raw)
To: Phil Sutter; +Cc: Pablo Neira Ayuso, netfilter-devel
Phil Sutter <phil@nwl.cc> wrote:
> Not sure if arch-specific, but for some reason src/nft wrapper script
> would call src/.libs/lt-nft and thus the owner appeared as 'lt-nft'
> instead of the expected 'nft'. Cover for that by extracting the expected
> program name from /proc.
I've seen this as well before, thanks for investigating and fixing it.
Acked-by: Florian Westphal <fw@strlen.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [nft PATCH] tests: shell: Fix owner/0002-persist on aarch64
2025-03-28 14:33 ` Florian Westphal
@ 2025-03-28 15:47 ` Phil Sutter
0 siblings, 0 replies; 3+ messages in thread
From: Phil Sutter @ 2025-03-28 15:47 UTC (permalink / raw)
To: Florian Westphal; +Cc: Pablo Neira Ayuso, netfilter-devel
On Fri, Mar 28, 2025 at 03:33:45PM +0100, Florian Westphal wrote:
> Phil Sutter <phil@nwl.cc> wrote:
> > Not sure if arch-specific, but for some reason src/nft wrapper script
> > would call src/.libs/lt-nft and thus the owner appeared as 'lt-nft'
> > instead of the expected 'nft'. Cover for that by extracting the expected
> > program name from /proc.
>
> I've seen this as well before, thanks for investigating and fixing it.
>
> Acked-by: Florian Westphal <fw@strlen.de>
Patch applied!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-28 15:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-28 14:09 [nft PATCH] tests: shell: Fix owner/0002-persist on aarch64 Phil Sutter
2025-03-28 14:33 ` Florian Westphal
2025-03-28 15:47 ` Phil Sutter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).