From: Pablo Neira Ayuso <pablo@netfilter.org>
To: fossdd <fossdd@pwned.life>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] configure: Avoid addition assignment operators
Date: Mon, 13 Jan 2025 23:25:10 +0100 [thread overview]
Message-ID: <Z4WSxlAq0_Ja2o44@calendula> (raw)
In-Reply-To: <D711RJX8FZM8.1ZZRJ5PYBRMID@pwned.life>
On Mon, Jan 13, 2025 at 04:08:34PM +0100, fossdd wrote:
> For compatability with other /bin/sh like busybox ash, since they don't
> support the addition assignment operators (+=) and otherwise fail with:
>
> ./configure: line 14174: regular_CFLAGS+= -D__UAPI_DEF_ETHHDR=0: not found
>
> Signed-off-by: fossdd <fossdd@pwned.life>
This solution looks OK to address the musl issue that we have
discussed.
Unfortunately, we don't take patches that abuse DCO via Signed-off-by:
that looks clearly made up.
next prev parent reply other threads:[~2025-01-13 22:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 15:08 [PATCH] configure: Avoid addition assignment operators fossdd
2025-01-13 22:25 ` Pablo Neira Ayuso [this message]
2025-01-14 2:56 ` fossdd
2025-01-26 17:13 ` fossdd
2025-01-28 12:01 ` Jeremy Sowden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4WSxlAq0_Ja2o44@calendula \
--to=pablo@netfilter.org \
--cc=fossdd@pwned.life \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).