netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Corubba Smith <corubba@gmx.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH ulogd2 2/8] ulogd: add ulogd_parse_configfile public function
Date: Wed, 12 Mar 2025 08:47:27 +0100	[thread overview]
Message-ID: <Z9E8D1XcLL2Lh_xW@strlen.de> (raw)
In-Reply-To: <4d7fe1dc-73ee-4e9e-b418-8f5fb87c1e4c@gmx.de>

Corubba Smith <corubba@gmx.de> wrote:
> Provide a new function `ulogd_parse_configfile()` in the public
> interface, which wraps `parse_config_file()` to parse a section of the
> config file and communicates found errors to the user. It can be used
> as a drop-in replacement because arguments and return value are
> compatible.

Most patches in this series no longer apply to ulogd2.git,
can you rebase and resend?

Thanks!

> +int ulogd_parse_configfile(const char *section, struct config_keyset *ce)
> +{
> +	int err;
> +
> +	err = config_parse_file(section, ce);
> +
> +	switch(err) {
> +		case 0:
> +			return ULOGD_IRET_OK;
> +			break;

Up to you if you want to change it or not; you can reduce one
indent level:

	switch(err) {
	case 0:
		return ULOGD_IRET_OK;
...

  reply	other threads:[~2025-03-12  7:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-08 22:32 [PATCH ulogd2 1/8] ulogd: fix config file fd leak Corubba Smith
2025-03-08 22:33 ` [PATCH ulogd2 2/8] ulogd: add ulogd_parse_configfile public function Corubba Smith
2025-03-12  7:47   ` Florian Westphal [this message]
2025-03-08 22:34 ` [PATCH ulogd2 3/8] all: use config_parse_file function in all plugins Corubba Smith
2025-03-08 22:35 ` [PATCH ulogd2 4/8] ulogd: raise error on unknown config key Corubba Smith
2025-03-08 22:36 ` [PATCH ulogd2 5/8] ulogd: ignore malformed config directives Corubba Smith
2025-03-08 22:37 ` [PATCH ulogd2 6/8] ulogd: improve integer option parsing Corubba Smith
2025-03-08 22:38 ` [PATCH ulogd2 7/8] ulogd: default configure implementation Corubba Smith
2025-03-08 22:39 ` [PATCH ulogd2 8/8] all: remove trivial configure hooks Corubba Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z9E8D1XcLL2Lh_xW@strlen.de \
    --to=fw@strlen.de \
    --cc=corubba@gmx.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).