From: Pablo Neira Ayuso <pablo@netfilter.org>
To: nicolas.bouchinet@clip-os.org
Cc: netfilter-devel@vger.kernel.org,
Nicolas Bouchinet <nicolas.bouchinet@ssi.gouv.fr>,
Jozsef Kadlecsik <kadlec@netfilter.org>
Subject: Re: [PATCH v2] netfilter: conntrack: Bound nf_conntrack sysctl writes
Date: Wed, 12 Mar 2025 21:08:57 +0100 [thread overview]
Message-ID: <Z9Hp2Tg5efDcC_Hj@calendula> (raw)
In-Reply-To: <20250129170633.88574-1-nicolas.bouchinet@clip-os.org>
On Wed, Jan 29, 2025 at 06:06:30PM +0100, nicolas.bouchinet@clip-os.org wrote:
> From: Nicolas Bouchinet <nicolas.bouchinet@ssi.gouv.fr>
>
> nf_conntrack_max and nf_conntrack_expect_max sysctls were authorized to
> be written any negative value, which would then be stored in the
> unsigned int variables nf_conntrack_max and nf_ct_expect_max variables.
>
> While the do_proc_dointvec_conv function is supposed to limit writing
> handled by proc_dointvec proc_handler to INT_MAX. Such a negative value
> being written in an unsigned int leads to a very high value, exceeding
> this limit.
This is applied to nf-next, thanks
prev parent reply other threads:[~2025-03-12 20:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-29 17:06 [PATCH v2] netfilter: conntrack: Bound nf_conntrack sysctl writes nicolas.bouchinet
2025-03-12 20:08 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9Hp2Tg5efDcC_Hj@calendula \
--to=pablo@netfilter.org \
--cc=kadlec@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nicolas.bouchinet@clip-os.org \
--cc=nicolas.bouchinet@ssi.gouv.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).